lpsetup

Merge lp:~frankban/lpsetup/fstab-tweak into lp:lpsetup

  1. fstab-tweak
  2. Merge into trunk
Proposed by Francesco Banconi
Status: Merged
Merged at revision: 13
Proposed branch: lp:~frankban/lpsetup/fstab-tweak
Merge into: lp:lpsetup
Diff against target: 17 lines (+7/-0)
1 file modified
lpsetup/subcommands/lxcinstall.py (+7/-0)
To merge this branch: bzr merge lp:~frankban/lpsetup/fstab-tweak
Reviewer Review Type Date Requested Status
Benji York (community) code Approve
Review via email: mp+102482@code.launchpad.net

Description of the change

== Changes ==

We need to add a line to the container's fstab in order to work around
bug 974584, still affecting lucid lxc.

The lxc-install sub command adds the line to fstab right after the container is created.

To post a comment you must log in.
Revision history for this message
Benji York (benji) wrote :

Looks good.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lpsetup/subcommands/lxcinstall.py'
2--- lpsetup/subcommands/lxcinstall.py 2012-04-10 16:36:15 +0000
3+++ lpsetup/subcommands/lxcinstall.py 2012-04-18 10:15:24 +0000
4@@ -134,6 +134,13 @@
5 dst = get_container_path(lxc_name, '/root/.ssh/')
6 mkdirs(dst)
7 shutil.copy(user_authorized_keys, dst)
8+ # XXX 2012-04-18 frankban bug=974584:
9+ # Add a line to the container's fstab to be able to create semaphores
10+ # in lxc. This workaround needs to be removed once the lxc bug is
11+ # resolved for lucid containers too.
12+ file_append(
13+ '/var/lib/lxc/{0}/fstab'.format(lxc_name),
14+ 'none dev/shm tmpfs defaults 0 0\n')
15
16
17 def start_lxc(lxc_name):

Subscribers

People subscribed via source and target branches

to all changes: