Launchpad itself

Merge lp:~frankban/launchpad/setuplxc-language-pack into lp:launchpad

  1. setuplxc-language-pack
  2. Merge into devel
Proposed by Francesco Banconi
Status: Merged
Approved by: Gary Poster
Approved revision: no longer in the source branch.
Merged at revision: 14897
Proposed branch: lp:~frankban/launchpad/setuplxc-language-pack
Merge into: lp:launchpad
Prerequisite: lp:~frankban/launchpad/setuplxc-add-apt-repository
Diff against target: 25 lines (+2/-6)
1 file modified
utilities/setuplxc.py (+2/-6)
To merge this branch: bzr merge lp:~frankban/launchpad/setuplxc-language-pack
Reviewer Review Type Date Requested Status
Gary Poster (community) Approve
Review via email: mp+94762@code.launchpad.net

Description of the change

== Changes ==

The environment variable LANG=C is used during launchpad dependencies
installation: this way we can avoid installing `language-pack-en`.

To post a comment you must log in.
Revision history for this message
Gary Poster (gary) wrote :

Great, thanks Francesco!

review: Approve
Revision history for this message
Francesco Banconi (frankban) wrote :

Thank Gary.

Revision history for this message
Francesco Banconi (frankban) wrote :

> Thanks Gary.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'utilities/setuplxc.py'
2--- utilities/setuplxc.py 2012-02-27 14:37:21 +0000
3+++ utilities/setuplxc.py 2012-02-27 14:37:22 +0000
4@@ -48,7 +48,7 @@
5 )
6 DEPENDENCIES_DIR = '~/dependencies'
7 DHCP_FILE = '/etc/dhcp/dhclient.conf'
8-HOST_PACKAGES = ['ssh', 'lxc', 'libvirt-bin', 'bzr', 'language-pack-en']
9+HOST_PACKAGES = ['ssh', 'lxc', 'libvirt-bin', 'bzr']
10 HOSTS_FILE = '/etc/hosts'
11 LP_APACHE_MODULES = 'proxy proxy_http rewrite ssl deflate headers'
12 LP_APACHE_ROOTS = (
13@@ -819,11 +819,7 @@
14 root_sshcall("echo 'mountall hold' | dpkg --set-selections")
15 # Upgrading packages.
16 root_sshcall(
17- 'apt-get update && '
18- 'DEBIAN_FRONTEND=noninteractive '
19- 'apt-get -y install language-pack-en')
20- root_sshcall(
21- 'DEBIAN_FRONTEND=noninteractive apt-get -y '
22+ 'apt-get update && DEBIAN_FRONTEND=noninteractive LANG=C apt-get -y '
23 'install {}'.format(LP_DEB_DEPENDENCIES))
24 # We install lxc in the guest so that lxc-execute will work on the
25 # container. We use --no-install-recommends at the recommendation