Merge lp:~frankban/launchpad/bug-1002820-rabbitmq-timeout-again into lp:launchpad

Proposed by Francesco Banconi on 2012-06-18
Status: Merged
Approved by: Francesco Banconi on 2012-06-18
Approved revision: no longer in the source branch.
Merged at revision: 15436
Proposed branch: lp:~frankban/launchpad/bug-1002820-rabbitmq-timeout-again
Merge into: lp:launchpad
Diff against target: 14 lines (+2/-1)
1 file modified
versions.cfg (+2/-1)
To merge this branch: bzr merge lp:~frankban/launchpad/bug-1002820-rabbitmq-timeout-again
Reviewer Review Type Date Requested Status
Benji York (community) code 2012-06-18 Approve on 2012-06-18
Review via email: mp+110822@code.launchpad.net

Commit Message

Fixed RabbitMQLayer:setUp timeout.

Description of the Change

= Summary =

RabbitMQLayer:setUp still times out.

== Proposed fix ==

Rather than increasing the timeout again, this time I've changed the relevant code to use an established amount of retries while waiting for the server to be up. This way we ensure the connection is checked for X times, without relying on the wall clock.
The real diff can be found here: http://pastebin.ubuntu.com/1047312/

No QA.

To post a comment you must log in.
Benji York (benji) wrote :

Looks good.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'versions.cfg'
2--- versions.cfg 2012-06-14 16:30:26 +0000
3+++ versions.cfg 2012-06-18 13:51:22 +0000
4@@ -104,8 +104,9 @@
5 RestrictedPython = 3.5.1
6 # lp-1 Build of lp:~benji/rabbitfixture/longer-timeout revision: r30
7 # lp-2 Build of lp:~frankban/rabbitfixture/longer-timeout revision: r32
8+# lp-3 Build of lp:~frankban/rabbitfixture/lp3 revision: r33
9 # to build: python setup.py sdist
10-rabbitfixture = 0.3.3-lp-2
11+rabbitfixture = 0.3.3-lp-3
12 roman = 1.4.0
13 # See http://code.google.com/p/selenium/issues/detail?id=1935 .
14 selenium = 2.0rc3-lp-distribute-fix