lp:~frankban/juju-quickstart/local-provider

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-quickstart at revision 18

Juju GUI Hackers: Pending requested 2013-11-20

Diff: 369 lines (+131/-39)

6 files modified

HACKING.rst (+19/-3)
quickstart/app.py (+24/-2)
quickstart/manage.py (+3/-7)
quickstart/tests/test_app.py (+68/-20)
quickstart/tests/test_manage.py (+12/-3)
quickstart/utils.py (+5/-4)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

22. By Francesco Banconi on 2013-11-20

Add missing manage test.

21. By Francesco Banconi on 2013-11-20

Checkpoint.

20. By Francesco Banconi on 2013-11-20

Add tests.

19. By Francesco Banconi on 2013-11-20

Checkpoint.

18. By Francesco Banconi on 2013-11-20

Working prototype.

17. By Brad Crittenden on 2013-11-19

Pass the bundle id when deploying.

If bundle: URL is used, pass the bundle id when deploying so Charmworld can
increment the counter.

R=matthew.scott, frankban
CC=
https://codereview.appspot.com/28520044

16. By Francesco Banconi on 2013-11-18

Document bundle debugging and releasing.

R=matthew.scott
CC=
https://codereview.appspot.com/28490043

15. By Francesco Banconi on 2013-11-18

Make quickstart idempotent.

- do not bootstrap an environment if already bootstrapped;
- do not deploy the GUI if already there.

Sorry, the diff is long, but there are a lot of tests.

Tests: make check

QA:
- .venv/bin/python juju-quickstart -e ec2
  and ensure the GUI is correctly deployed;

- .venv/bin/python juju-quickstart -e ec2
  again, to check it recognizes that env is
  already bootstrapped and the
  GUI unit is already there;

In the following steps, sometimes the browser
can get confused about certs, wss conections
etc. If the GUI is not loading correctly,
try harder, use incognito mode, change the
browser.

- juju destroy-service -e ec2 juju-gui;
- .venv/bin/python juju-quickstart -e ec2
  again, to check the service and the unit
  are correctly re-deployed;

Incidentally the step above, in the case it
succeeds, also demonstrates that the GUI can
safely be redeployed in the same machine: I
wasn't sure about this and this means we are
cleaning up things correctly in our charm, yay!

- juju unexpose -e ec2 juju-gui;
- .venv/bin/python juju-quickstart -e ec2
  again, to check that the service is
  properly re-exposed;

- juju destroy-unit -e ec2 juju-gui/0;
- .venv/bin/python juju-quickstart -e ec2
  again, to check that the unit is
  re-added on the existing service
  (this time it should be named juju-gui/1);

- juju destroy-service -e ec2 juju-gui;
- juju deploy -e ec2 juju-gui (if juju exits with a
  "service already exists" error, retry after a while);
- .venv/bin/python juju-quickstart -e ec2 \
    bundle:~jorge/mediawiki-simple/4/mediawiki-simple;
The last command, executed right after juju-deploy should
also demonstrates that incidentally quickstart
can also be used to watch an already running
deployment, and that a bundle can still be deployed;

Final check:
- .venv/bin/python juju-quickstart -e ec2;
just to ensure quickstart is not surprised
that the unit is not in the bootstrap node
(i.e. you should see "juju-gui/0 is ready on machine 1").

Thanks a lot for testing all of this.
I added a card to automate the QA above with
a collection of functional tests.

Remember to destroy your ec2 environment.

R=gary.poster, rharding
CC=
https://codereview.appspot.com/28250044

14. By Francesco Banconi on 2013-11-14

Update the quickstart test venv set up process.

Remove the activate file if the requirements
installation process fails.

Also updated the default GUI charm URL, and
the documentation.

R=gary.poster
CC=
https://codereview.appspot.com/26540043

13. By Francesco Banconi on 2013-11-13

Put constant parameters in a separate module.

Added a settings module where to store constants
reused in different parts of the application.

This is just a mechanical branch and it does
not include other changes.

R=gary.poster
CC=
https://codereview.appspot.com/26060043