lp:~frankban/juju-quickstart/improve-field-choices

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-quickstart at revision 43

Juju GUI Hackers: Pending requested 2014-01-07

Diff: 293 lines (+132/-19)

7 files modified

quickstart/cli/forms.py (+30/-7)
quickstart/cli/ui.py (+3/-0)
quickstart/cli/views.py (+7/-2)
quickstart/models/envs.py (+1/-0)
quickstart/tests/cli/test_forms.py (+85/-6)
quickstart/tests/cli/test_views.py (+5/-3)
quickstart/tests/models/test_fields.py (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

50. By Francesco Banconi on 2014-01-08

Checkpoint.

49. By Francesco Banconi on 2014-01-07

Checkpoint.

48. By Francesco Banconi on 2014-01-07

Some changes as per review.

47. By Francesco Banconi on 2014-01-07

Checkpoint.

46. By Francesco Banconi on 2014-01-07

DefaultSeriesField tests.

45. By Francesco Banconi on 2014-01-07

Fix all the tests.

44. By Francesco Banconi on 2014-01-07

Handle default series.

43. By Francesco Banconi on 2014-01-07

Implement clickable choices.

42. By Francesco Banconi on 2014-01-03

Enable tab navigation in forms.

Implemented a TabNavigationListBox
that can be used when tab navigation is
required.

Also fixed views' status messages.

Tests: `make check`.

QA: start the demo app
(`make` and `./cli-app-demo.py).
Use it to edit existing environments and
to create new ones (ec2 and local).
Check that the status messages make sense.
In the creation/edit forms you should
be able to navigate through the form fields
using tab and shift+tab.

R=bac
CC=
https://codereview.appspot.com/47350044

41. By Francesco Banconi on 2014-01-03

Implement the environment create/edit view.

Add a cli/forms.py module including helpers
to create and handle Urwid forms.

Allow for creating a new environment from the
env_index view.

Implement the env_edit view, used for creating
or updating environments.

Fix a corner case in envs.set_env_data: delete
the env_db default key only if the environments
has been modified.

Tests: `make check`.

QA: start the demo app
(`make` and `./cli-app-demo.py).
Use it to edit existing environments and
to create new ones (ec2 and local).
Check form errors are correctly handled.
Exit the demo app with either ^X or
selecting an environment to use. The
demo app should show changes on exit,
and notify whether a new db has been saved
and/or an environment has been selected.

R=gary.poster, benji1
CC=
https://codereview.appspot.com/44750044