Reviewers: mp+248755_code.launchpad.net, Message: Please take a look. Description: Make ftests fail if Juju env is not ready. The functional tests are no longer silently skipped if the default Juju environment cannot be found. Also fail if the environment is running, as this would cause it to be destroyed at the end of the suite. QA: - bootstrap your default environment; - run `make ftest`/`make fcheck` and ensure the functional tests fail (environment already bootstrapped); - destroy your environment; - run `make fcheck` again and ensure all the suites complete successfully. https://code.launchpad.net/~frankban/juju-quickstart/ftest-fixes/+merge/248755 (do not edit description out of merge proposal) Please review this at https://codereview.appspot.com/195690043/ Affected files (+48, -11 lines): M HACKING.rst A [revision details] M quickstart/tests/functional/test_functional.py Index: HACKING.rst === modified file 'HACKING.rst' --- HACKING.rst 2015-01-30 18:06:46 +0000 +++ HACKING.rst 2015-02-05 13:35:53 +0000 @@ -85,6 +85,7 @@ bootstrapped in the process; - a Juju home correctly set up with at least one environment defined in the ``environments.yaml`` file; +- the selected Juju environment not to be in use; - SSH keys already generated for the user running the tests; - a working Internet connection. @@ -94,7 +95,7 @@ make fcheck JUJU_ENV=myenv The environment used by the functional suite is destroyed after the tests -complete. For this reason, **ensure the selected environment is not in use**. +complete. The tests fail the selected environment is already in use. To run the test using a customized build of Juju, pass the ``JUJU`` environment variable to ``make``, e.g.:: Index: [revision details] === added file '[revision details]' --- [revision details] 2012-01-01 00:00:00 +0000 +++ [revision details] 2012-01-01 00:00:00 +0000 @@ -0,0 +1,2 @@ +Old revision: