lp:~frankban/juju-quickstart/fix-manifest

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-quickstart at revision 58

Juju GUI Hackers: Pending requested 2014-03-13

Diff: 27 lines (+3/-1)

2 files modified

MANIFEST.in (+2/-0)
quickstart/__init__.py (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1291928: PyPI source tarball is missing Makefile

High

Fix Released

Link a bug report

Related blueprints

58. By Francesco Banconi on 2014-03-13

Add missing files to manifest.

57. By Francesco Banconi on 2014-03-12

Update requirements.

Make quickstart use the newer python-jujuclient
included in trusty.

R=rharding
CC=
https://codereview.appspot.com/74610043

56. By Francesco Banconi on 2014-03-11

Improve version handling.

Modify the app.ensure_dependencies function
so that it returns the Juju version tuple.
This way we allow for reusing the version
through the app and we can avoid calling
"juju version" multiple times.

Support local environments by installing
the juju-local meta-package in place of
specific packages (e.g. lxc, mongo).
This way we don't have to update quickstart
if core devs introduce new local env
dependencies.

Fix the destroy-environment message displayed
at the end of the process. The -e flag is
included when an old Juju is used.

Tests: `make check`.

QA: no strictly required.
Use .venv/bin/python juju-quickstart, check everything
works well, check the destroy-environment message
at the end of the process.

R=rharding, matthew.scott
CC=
https://codereview.appspot.com/74010044

55. By Francesco Banconi on 2014-03-10

SSH code reorganization.

This branch introduces a new ssh module
containing SSH handling related code.

The SSH functions previously in app are now
library functions in the ssh module.

ensure_ssh_keys is now the only app entry point
for the whole SSH keys management logic.

For the reasons above this branch mostly includes
code movements + some docstring/comments changes +
some exception handling changes.

R=jeff.pihach, bac
CC=
https://codereview.appspot.com/72520044

54. By Francesco Banconi on 2014-02-19

Minor changes in preparation for release.

Bump version up to 1.1.0.
Re-organize the "requires sudo" code.
Restore 100% unit test coverage (compulsive mode on).
Update license headers of modified files.

Tests: `make check`
QA: use quickstart as usual, bootstrapping
both ec2 and local environments.

R=rharding
CC=
https://codereview.appspot.com/65970043

53. By Brad Crittenden on 2014-02-03

[r=makyo] Use existing ssh-agent if possible. Don't start ssh-agent for realz in tests.

52. By Jeff Pihach on 2014-01-31

When bootstrapping, if the Juju version is less than 1.17.2
then quickstart will use sudo when deploying a new environment.

On versions higher than 1.17.2 sudo is no longer required and
quickstart will no longer use it.

51. By Francesco Banconi on 2014-01-30

Minor fixes to code comments and documentation

Also fixed a possible encoding problem in error handling.

The get_admin_secret function and its test case are just moved, no
need to re-review.

Tests: `make check`.
No QA.

R=bac
CC=
https://codereview.appspot.com/58680043

50. By Brad Crittenden on 2014-01-29

Get admin_secret from juju-generated jenv file.

As of Juju v 1.17 the admin-secret is stored in a generated file, located in
$JUJU_HOME/environments/<environment>.jenv.

If an admin-secret is provided in environments.yaml, it is used and also
stored in the jenv file. If none is given, then juju fabricates one and
stores it in the jenv file.

The admin-secret *field* is marked as optional now. For the case where a
local environment is used, Quickstart previously would generate an
admin-secret. That behavior is maintained by forcing 'admin-secret' to be in
the missing_fields list. This approach ensures backwards compatibility.

Note that the Juju-generated admin-secret is not available until after
bootstrapping the environment. Due to this behavior, when using juju v1.16
and not admin-secret is configured in the environments.yaml file, the failure
will not be reported until after bootstrapping. This approach seemed better
than introducing hard version checking.

R=frankban
CC=
https://codereview.appspot.com/57900043

49. By Francesco Banconi on 2014-01-29

Update for PyPI release.

R=gary.poster
CC=
https://codereview.appspot.com/51790045