Merge lp:~frankban/juju-quickstart/fix-functional-test into lp:juju-quickstart

Proposed by Francesco Banconi
Status: Merged
Merged at revision: 138
Proposed branch: lp:~frankban/juju-quickstart/fix-functional-test
Merge into: lp:juju-quickstart
Diff against target: 12 lines (+1/-1)
1 file modified
quickstart/tests/functional/test_functional.py (+1/-1)
To merge this branch: bzr merge lp:~frankban/juju-quickstart/fix-functional-test
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+262231@code.launchpad.net

Description of the change

Fix uncommitted bundle ftest.

Avoid using a no longer existing openstack bundle.

https://codereview.appspot.com/245370043/

To post a comment you must log in.
Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+262231_code.launchpad.net,

Message:
Please take a look.

Description:
Fix uncommitted bundle ftest.

Avoid using a no longer existing openstack bundle.

https://code.launchpad.net/~frankban/juju-quickstart/fix-functional-test/+merge/262231

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/245370043/

Affected files (+3, -1 lines):
   A [revision details]
   M quickstart/tests/functional/test_functional.py

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision:
<email address hidden>
+New revision:
<email address hidden>

Index: quickstart/tests/functional/test_functional.py
=== modified file 'quickstart/tests/functional/test_functional.py'
--- quickstart/tests/functional/test_functional.py 2015-05-29 16:29:19 +0000
+++ quickstart/tests/functional/test_functional.py 2015-06-17 14:28:38 +0000
@@ -184,7 +184,7 @@
      def test_uncommitted_bundle_deployment(self):
          # The application can be used to deploy uncommitted bundles.
          retcode, output, error = run_quickstart(
- self.env_name, '-u', 'u/openstack-charmers/openstack/25')
+ self.env_name, '-u', 'openstack-base/34')
          self.assertEqual(0, retcode)
          self.assertIn('the bundle is ready to be deployed', output)
          self.assertEqual('', error)

Revision history for this message
Francesco Banconi (frankban) wrote :
Revision history for this message
Francesco Banconi (frankban) wrote :

*** Submitted:

Fix uncommitted bundle ftest.

Avoid using a no longer existing openstack bundle.

R=
CC=
https://codereview.appspot.com/245370043

https://codereview.appspot.com/245370043/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'quickstart/tests/functional/test_functional.py'
2--- quickstart/tests/functional/test_functional.py 2015-05-29 16:29:19 +0000
3+++ quickstart/tests/functional/test_functional.py 2015-06-17 14:43:03 +0000
4@@ -184,7 +184,7 @@
5 def test_uncommitted_bundle_deployment(self):
6 # The application can be used to deploy uncommitted bundles.
7 retcode, output, error = run_quickstart(
8- self.env_name, '-u', 'u/openstack-charmers/openstack/25')
9+ self.env_name, '-u', 'openstack-base/34')
10 self.assertEqual(0, retcode)
11 self.assertIn('the bundle is ready to be deployed', output)
12 self.assertEqual('', error)

Subscribers

People subscribed via source and target branches