lp:~frankban/juju-gui/service-detail-delete-fix

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-gui/experimental at revision 920

Juju GUI Hackers: Pending requested 2013-08-02

Diff: 12 lines (+1/-1)

1 file modified

app/views/service.js (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1207708: cannot destroy service from the service details view

High

Fix Released

Link a bug report

Related blueprints

920. By Francesco Banconi on 2013-08-02

FIxed service detail view delete button.

919. By Francesco Banconi on 2013-08-02

Fix the service menu bug.

The service menu is no longer displayed when
the service is dragged in the topology.

R=
CC=
https://codereview.appspot.com/12342043

918. By Francesco Banconi on 2013-08-02

Gary's branch with the Python server fix.

This branch includes Gary's cache changes from
https://codereview.appspot.com/12306043/

Added a fix to the Python HTTP server used
when the GUI is run with make debug/prod.

R=
CC=
https://codereview.appspot.com/12335043

917. By Jeff Pihach on 2013-08-01

Ghost default configuration toggle

This implements the 'use default configuration' toggle in the
ghost inspector. It's active by default and all inputs and
text areas are disabled when it's active. Clicking the toggle
will re-enable all inputs. If you have changed some options
then click the toggle it will reset all values to their
defaults.

R=j.c.sackett, rharding, benjamin.saller
CC=
https://codereview.appspot.com/12205043

916. By Huw Wilkins on 2013-08-01

Add SCSS support

Added SCSS building to the template builders.

At the moment we're building LESS and SCSS but we can remove LESS once the CSS files have been migrated over.

I've added a new folder in the standard assets folder, all CSS wil eventually be migrated to the new folder. Anything in the new directory will be built using SCSS.

I ended up use the node-sass model instead of pysass as our build setup is designed to use Node models already. If anyone has an issue we could add additional build steps to replace this in Python.

R=
CC=
https://codereview.appspot.com/12148043

915. By j.c.sackett on 2013-07-31

Removes remaining references to charm store

-Deletes CharmStore from app/store/charm
-Deletes test util references to CharmStore
-Removes CharmStore from the app
-Removes confusing references to charm browser as charmstore by renaming the
subapp charmbrowser where necessary
-Cleanup
-Docs
-Test updates

R=bac, benji
CC=
https://codereview.appspot.com/12029045

914. By Jeff Pihach on 2013-07-31

Impl destroy ghost and service

This adds the destroy ghost and destroy service functionality
to match the V11 mockups. I took some engineer-license and
implemented a confirmation dialogue as well.

R=benjamin.saller, gary.poster
CC=
https://codereview.appspot.com/12050049

913. By j.c.sackett on 2013-07-30

Removes charm store from fakebackend

-Rewrote the backend to use the API store to query for the charm.
-Updated model to provide the storeId in charmParts instead of the no longer
needed charm_store_path
-Updated model to set requires/provides from the API relations data.
-Added api-response json files for tests
-Provided new cached_charms in tests using new API data, and created new
FakeBackend (without charmstore)
-Updated tests, including using actual charm IDs; the old ones only worked
because the test processing ignored id validation.
-Drive bys.

R=jeff.pihach, matthew.scott
CC=
https://codereview.appspot.com/12115043

912. By Kapil Thangavelu on 2013-07-30

Fix boolean export from gui.

This updates the js-yaml with a fix for escaping string values which are yaml
1.1 aliases for booleans. By default js-yaml implements 1.2 which does away with
these aliases, resulting in roundtripping issues between gui and python or golang.

R=teknico, benji, gary.poster
CC=
https://codereview.appspot.com/11966044

911. By Madison Scott-Clary on 2013-07-30

Normalize window.flags in tests

window.flags now works just as it does in the app: it is set in test/index.html to an empty object (since the tests don't have the :flags: ns), and each test or each feature (usually divided up into suites, as they should be) deals solely with that feature flag only. If flags are set in a 'before', only those flags are unset in 'after', etc. This is as much a policy proposal as a branch, and I've created a weekly card to discuss.

R=gary.poster, rharding
CC=
https://codereview.appspot.com/12060044