lp:~frankban/juju-gui/bug-1229939-service-set

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:juju-gui/experimental

Juju GUI Hackers: Pending requested 2013-09-25

Diff: 211 lines (+50/-61)

6 files modified

app/store/env/go.js (+10/-10)
app/store/env/sandbox.js (+26/-35)
test/test_env_go.js (+6/-8)
test/test_inspector_settings.js (+1/-1)
test/test_sandbox_go.js (+4/-4)
test/test_service_config_view.js (+3/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1087. By Francesco Banconi on 2013-09-25

Checkpoint.

1086. By Madison Scott-Clary on 2013-09-24

Charm updated notification

This adds a notification to the inspector when a charm has been changed for a service.

To QA:

1. Deploy a service
2. Open the inspector
3. Open the javascript console, and type:

   app.db.services.item(0).set('charmChanged', true);

4. The notification should appear below the service header

R=jeff.pihach
CC=
https://codereview.appspot.com/13705045

1085. By Gary Poster on 2013-09-24

Refactor content panel for re-use.

The content panel that has been used in the sidebar and the inspector wasn't
very flexible and now that we want to use it for bundles I've cleaned it up so
that we can re-use it without as much trouble.

R=
CC=
https://codereview.appspot.com/13865043

1084. By Gary Poster on 2013-09-24

Data-bind unit details view

Our unit detail view was not data-bound: it would render and never update. This branch fixes that, except for the relation information, which is not really available at the moment (in terms of errors) so I decided that could live to fight another day.

R=jeff.pihach
CC=
https://codereview.appspot.com/13841044

1083. By Brad Crittenden on 2013-09-24

Remove old Charm and CharmList.

R=j.c.sackett
CC=
https://codereview.appspot.com/13255052

1082. By Benji York on 2013-09-24

Generisize charm tokens more to just "tokens".

This is (hopefully) the last stop before rudimentary bundle tokens are
possible.

R=bac
CC=
https://codereview.appspot.com/13860044

1081. By Brad Crittenden on 2013-09-24

Fix failing test.

done() was called before the end of setup.

R=jeff.pihach
CC=
https://codereview.appspot.com/13858045

1080. By Jeff Pihach on 2013-09-24

Updated hacking docs with missing information

R=
CC=
https://codereview.appspot.com/13828044

1079. By Benjamin Saller on 2013-09-24

Repair remove unit button

Python and Go have differnt remove unit signatures, we
called it in a loop with single names but the go env still
expected an array, not a string. This will conditionally
trigger the behavior based on env type.

R=jeff.pihach
CC=
https://codereview.appspot.com/13832044

1078. By Benjamin Saller on 2013-09-24

Deploy charms without config options

QA showed that charms that didn't include options would trigger a number
of minor errors progressing down code paths that expected options. This
adds a test with the puppermaster charm and show successful deployment.

R=frankban, jeff.pihach, benjamin.saller
CC=
https://codereview.appspot.com/13852043