Code review comment for lp:~frankban/charms/precise/juju-gui/trusty-charm
Revision history for this message
| Francesco Banconi (frankban) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Please take a look.
https:/
File HACKING.md (right):
https:/
HACKING.md:24: way to get started. See
https:/
On 2014/04/15 13:50:16, bac wrote:
> Do you prefer pypi to the package just because we have tighter control
over it
> and it may be more up-to-date?
I prefer PyPI because the page automatically shows the most recent
quickstart README, including installation instructions.
https:/
HACKING.md:62: version the charm will be deployed by functional tests.
For instance, to test
On 2014/04/15 13:50:16, bac wrote:
> This sentence ends clumsily. How about
> Since functional tests deploy the charm in the
> bootstrap node, setting the default series also selects which series
> version the charm will be deployed by functional tests.
Done.
https:/
HACKING.md:66: Long story short, to run both unit and functional the
tests:
On 2014/04/15 13:50:16, bac wrote:
> s/the tests/tests/
Done.
https:/
HACKING.md:128: The `make deploy` command also support specifying the OS
version used to deploy
On 2014/04/15 13:50:16, bac wrote:
> s/support/supports/
Done.
https:/
File Makefile (right):
https:/
Makefile:83: @echo 'make deploy [JUJU_ENV=
[SERIES="trusty"] - Deploy and'
On 2014/04/15 13:50:16, bac wrote:
> Shouldn't this say SERIES=
trusty because
> precise is the default?
Yes, "trusty" is just an example, and "precise" is the default.
https:/
File README.md (right):
https:/
README.md:47: add additional machines (i.e. the GUI is installed in the
bootstrap node).
On 2014/04/15 13:50:16, bac wrote:
> Two parenthetic i.e. clauses in one sentence is a red flag. How
about:
> When possible, Quickstart conserves resources by installing the GUI on
the
> bootstrap node. This colocation is not possible when using a local
(LXC)
> environment.
Done.
https:/
README.md:165: While the Juju GUI itself is a client side JavaScript
application, the charm
On 2014/04/15 13:50:16, bac wrote:
> trivial: client-side
Done.
https:/
README.md:166: installation also involves configuring a starting a GUI
server, which is
On 2014/04/15 13:50:16, bac wrote:
> configuring and starting?
Done.
https:/
README.md:205: * The legacy server is no longer supported/tested staring
from trusty.
On 2014/04/15 13:50:16, bac wrote:
> typo:starting
Done, also fixed in the config.yaml.
https:/