Juju Charms Collection
buildbot-slave package

Merge lp:~frankban/charms/oneiric/buildbot-slave/urandom-script-argument into lp:~yellow/charms/oneiric/buildbot-slave/trunk

  1. Oneiric (11.10)
  2. urandom-script-argument
  3. Merge into trunk
Proposed by Francesco Banconi on 2012-03-23
Status: Merged
Approved by: Gary Poster on 2012-03-23
Approved revision: 25
Merged at revision: 25
Proposed branch: lp:~frankban/charms/oneiric/buildbot-slave/urandom-script-argument
Merge into: lp:~yellow/charms/oneiric/buildbot-slave/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
examples/lpbuildbot.yaml (+1/-1)
To merge this branch: bzr merge lp:~frankban/charms/oneiric/buildbot-slave/urandom-script-argument
Reviewer Review Type Date Requested Status
Gary Poster (community) 2012-03-23 Approve on 2012-03-23
Review via email: mp+99056@code.launchpad.net

Description of the Change

Updated setuplxc args to include the random/urandom hack.

To post a comment you must log in.
Gary Poster (gary) wrote :

We could also propose this to the official charm...it would be nice if it were part of a more important general change so that we wouldn't have to distract them for such a small thing that only we care about. :-/ Not sure, but I am ok with not making an MP for the official charm yet if you don't want to, even though it makes me worried.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'examples/lpbuildbot.yaml'
2--- examples/lpbuildbot.yaml 2012-03-10 13:58:10 +0000
3+++ examples/lpbuildbot.yaml 2012-03-23 15:52:19 +0000
4@@ -5,7 +5,7 @@
5 script-path: setuplxc.py
6 # The buildbot user's home directory is /var/lib/buildout.
7 # The LP dependencies will be in /var/lib/buildout/dependencies.
8- script-args: "-u buildbot -e launchpad-pqm@canonical.com -f 'Launchpad PQM' -s launchpad_lxc_id_rsa {installdir}"
9+ script-args: "-u buildbot -e launchpad-pqm@canonical.com -f 'Launchpad PQM' -s launchpad_lxc_id_rsa --use-urandom {installdir}"
10 extra-repository: deb http://us.archive.ubuntu.com/ubuntu/ lucid main universe
11 buildbot-pkg: buildbot/lucid
12 extra-packages: testrepository

Subscribers

People subscribed via source and target branches