Merge lp:~frankban/charms/oneiric/buildbot-master/trunk into lp:~yellow/charms/oneiric/buildbot-master/trunk

Proposed by Francesco Banconi
Status: Merged
Approved by: Gary Poster
Approved revision: 8
Merged at revision: 8
Proposed branch: lp:~frankban/charms/oneiric/buildbot-master/trunk
Merge into: lp:~yellow/charms/oneiric/buildbot-master/trunk
Diff against target: 39 lines (+5/-11)
3 files modified
hooks/stop (+1/-1)
metadata.yaml (+3/-9)
revision (+1/-1)
To merge this branch: bzr merge lp:~frankban/charms/oneiric/buildbot-master/trunk
Reviewer Review Type Date Requested Status
Gary Poster (community) Approve
Review via email: mp+90732@code.launchpad.net

Description of the change

The buildbot master charm now provides a buildbot relationship with *master* interface.

To post a comment you must log in.
8. By Francesco Banconi

Merged parent branch and resolved conflicts.

Revision history for this message
Gary Poster (gary) wrote :

Looks good, thank you. I agree that the master should provide an interface, and the slave should require that interface.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/stop'
2--- hooks/stop 2012-01-17 21:36:50 +0000
3+++ hooks/stop 2012-01-30 17:06:23 +0000
4@@ -10,7 +10,7 @@
5
6 juju-log "<-- stop"
7 juju-log "Stopping buildbot in $BUILDBOT_DIR"
8-close-port 8010/tcp
9+close-port 8010/TCP
10 buildbot stop $BUILDBOT_DIR
11 juju-log "Finished stopping buildbot"
12 juju-log "--> stop"
13
14=== modified file 'metadata.yaml'
15--- metadata.yaml 2012-01-30 14:43:09 +0000
16+++ metadata.yaml 2012-01-30 17:06:23 +0000
17@@ -13,12 +13,6 @@
18 counts, lint checks, image size, compile time, and other build
19 parameters can be tracked over time, are more visible, and are
20 therefore easier to improve.
21-#provides:
22-# relation-name:
23-# interface: interface-name
24-#requires:
25-# relation-name:
26-# interface: interface-name
27-#peers:
28-# relation-name:
29-# interface: interface-name
30+provides:
31+ buildbot:
32+ interface: master
33
34=== modified file 'revision'
35--- revision 2012-01-25 21:45:49 +0000
36+++ revision 2012-01-30 17:06:23 +0000
37@@ -1,1 +1,1 @@
38-45
39+48

Subscribers

People subscribed via source and target branches