Code review comment for lp:~franciscosouza/pyjuju/juju-vpc

Revision history for this message
Chico (franciscossouza) wrote :

https://codereview.appspot.com/6850044/diff/7017/juju/providers/ec2/securitygroup.py
File juju/providers/ec2/securitygroup.py (right):

https://codereview.appspot.com/6850044/diff/7017/juju/providers/ec2/securitygroup.py#newcode11
juju/providers/ec2/securitygroup.py:11: for group in d.result:
On 2012/11/22 13:44:07, hazmat wrote:
> This is very suspect, deferred results should not be access directly,
this needs
> a callback registered or inlineCallbacks syntax.

Thanks, I will fix this.

I will also stop updating this CL using lbox, so you guys stop receiving
notifications. There is more than VPC in this CL now (proxy,
pre-installed juju, etc.), and we will probably keep using this fork. I
hope that we will be able to send smaller patchs for merging in the
(near) future.

https://codereview.appspot.com/6850044/

« Back to merge proposal