pyjuju

Code review comment for lp:~franciscosouza/pyjuju/juju-vpc

  1. juju-vpc
  2. Merge into trunk
Revision history for this message
Kapil Thangavelu (hazmat) wrote :

one comment regarding correctness.

https://codereview.appspot.com/6850044/diff/7017/juju/providers/ec2/securitygroup.py
File juju/providers/ec2/securitygroup.py (right):

https://codereview.appspot.com/6850044/diff/7017/juju/providers/ec2/securitygroup.py#newcode11
juju/providers/ec2/securitygroup.py:11: for group in d.result:
This is very suspect, deferred results should not be access directly,
this needs a callback registered or inlineCallbacks syntax.

https://codereview.appspot.com/6850044/

Reply

« Back to merge proposal