Code review comment for lp:~franciscosouza/pyjuju/juju-vpc

Revision history for this message
Chico (franciscossouza) wrote :

Reviewers: mp+134169_code.launchpad.net,

Message:
Please take a look.

Description:
providers/ec2: support VPC

To use VPC, all the user need to do is add two new environment settings:
vpc_id
and subnet_id.

This CL depends on three other CLs (related to txaws):

  - https://codereview.appspot.com/6826065/
  - https://codereview.appspot.com/6822097/
  - https://codereview.appspot.com/6814123/

https://code.launchpad.net/~franciscosouza/juju/juju-vpc/+merge/134169

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/6850044/

Affected files:
   A [revision details]
   M juju/providers/ec2/launch.py
   M juju/providers/ec2/securitygroup.py
   M juju/providers/ec2/tests/common.py
   M juju/providers/ec2/tests/test_bootstrap.py
   M juju/providers/ec2/tests/test_launch.py
   M juju/providers/ec2/tests/test_securitygroup.py
   M juju/providers/ec2/tests/test_shutdown.py

« Back to merge proposal