Merge lp:~francesco-marella/entertainer/manager-desktop-file into lp:entertainer

[Francesco Marella]

Add a link to the Entertainer's Manager in System > Preferences menu. (Francesco Marella)

[Matt Layman (mblayman)]

Francesco,

This branch is great in helping us expose some more of the pieces that a user will have to interact with. One small thing to fix. Please change the setup so that it is just one call to data_files.append for 'share/applications' rather than two. You can look at 'share/entertainer/docs' right above 'share/applications' for an example of what I mean. Please let me know if you have questions.

Thanks,
Matt

review: Needs Fixing

[lp:~francesco-marella/entertainer/manager-desktop-file]

408. By Francesco Marella on 2010-05-17

Call data_files.append for 'share/applications' just one time.

[Francesco Marella (francesco-marella)]

> Francesco,
>
> This branch is great in helping us expose some more of the pieces that a user
> will have to interact with. One small thing to fix. Please change the setup so
> that it is just one call to data_files.append for 'share/applications' rather
> than two. You can look at 'share/entertainer/docs' right above
> 'share/applications' for an example of what I mean. Please let me know if you
> have questions.
>
> Thanks,
> Matt

Matt, thanks for taking the time to review this merge request.
I have done the changes as requested.

-fm

[Matt Layman (mblayman)]

Looks good now.

review: Approve

=== added file 'docs/entertainer-manager.desktop'
--- docs/entertainer-manager.desktop	1970-01-01 00:00:00 +0000
+++ docs/entertainer-manager.desktop	2010-05-17 09:22:24 +0000
@@ -0,0 +1,11 @@
+[Desktop Entry]
+Version=1.0
+Name=Entertainer Manager
+Comment=Manager for Entertainer Media Center
+Exec=entertainer-manager
+Icon=entertainer
+Terminal=false
+Type=Application
+Categories=GTK;GNOME;Settings;
+X-GNOME-FullName=Entertainer Manager
+X-GNOME-Gettext-Domain=entertainer-manager

=== modified file 'setup.py'
--- setup.py	2010-05-16 19:29:08 +0000
+++ setup.py	2010-05-17 09:22:24 +0000
@@ -65,7 +65,10 @@
         'docs/DEPENDENCIES',
         ]))
 data_files.append(
-    ('share/applications', ['docs/entertainer.desktop']))
+    ('share/applications', [
+        'docs/entertainer.desktop',
+        'docs/entertainer-manager.desktop',
+        ]))
 data_files.append(
     ('share/man/man1', ['docs/entertainer.1.gz']))