lp:~fpstovall/nrtb/unique_ptr_fix

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:nrtb

Rick Stovall: Approve on 2012-04-03

Diff: 1067 lines (+405/-334)

7 files modified

common/sockets/Makefile (+3/-3)
common/sockets/base_socket.cpp (+97/-112)
common/sockets/base_socket.h (+2/-2)
common/sockets/socket_test.cpp (+98/-80)
common/transceiver/Makefile (+2/-2)
common/transceiver/transceiver.h (+44/-36)
common/transceiver/transceiver_test.cpp (+159/-99)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

21. By Rick Stovall on 2012-04-01

Removed an unneeded reference to the boost::shared_ptr header in the socket unit test.

20. By Rick Stovall on 2012-04-01

1. Significant cleanups to the tcp_server_socket_factory, particularly in the run() (listener) method, providing improved clarity and stability and error reporting.
2. It is now an error for tcp_server_socket_factory::on_accept() to fail to take posession of connect_sock.
3. Defined tcp_server_socket_factory::last_fault(); it had been declared 12 years ago, but apparently I had never actaully finished it.
4. Cleaned up and refined socket_test.cpp to improve error reporting and comply with proper use of the newly unique tcp_socket_p.

19. By Rick Stovall on 2012-04-01

Completed and passes unit tests. THere is an occassional failure to connect to the listener socket which may be indicative of a gap in tcp_server_socket_factory::start_listen(), as it looks like the listener is not getting started properly. However, even in that case we fail gracefully.

18. By Rick Stovall on 2012-03-31

Added the C0x switch to the linker step to ensure the proper libs are linked.

17. By Rick Stovall on 2012-03-29

1. Added a new bool is_connected() method to transciever.
2. Corrected a couple of cases in the transciever test where I was attempting to access a unique_ptr after ownership was handed off.

16. By Rick Stovall on 2012-03-19

Three changes to the transceiver test code:
   1. Moved the declaration of the test server out to the global scope from inside the server socket factory.
   2. Added a smarter loop to wait for server startup.
   3. Removed the define in the Makefile suppressing the boost::circular_buffer debug code.

Not compiled or tested yet.

15. By Rick Stovall on 2012-03-16

Numerous cleanups on the transceiver test code to increase reliability. Not compiled yet.

14. By Rick Stovall on 2012-03-15

More tranceiver fixes to use unique_ptr<>. This version builds but does not pass unit tests yet.

13. By Rick Stovall on 2012-03-15

Numerious changes to Tranceiver.. still resolveing an issue with circular buffer.

12. By Rick Stovall on 2012-03-15

Corrected to use the proper header for std::unique_ptr<>.