Merge lp:~foxoman/unity/fix-for-bug-924354 into lp:unity

Proposed by Sultan Al-Isaiee
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: no longer in the source branch.
Merged at revision: 2131
Proposed branch: lp:~foxoman/unity/fix-for-bug-924354
Merge into: lp:unity
Diff against target: 12 lines (+1/-1)
1 file modified
plugins/unityshell/src/BFBLauncherIcon.cpp (+1/-1)
To merge this branch: bzr merge lp:~foxoman/unity/fix-for-bug-924354
Reviewer Review Type Date Requested Status
Tim Penhey (community) Approve
Thomi Richards (community) Approve
John Lea Pending
Review via email: mp+92681@code.launchpad.net

Commit message

change Dash Home tooltip to use header capitalization from "Dash home" to "Dash Home" lp:924354

Description of the change

change Dash Home tooltip to use header capitalization from "Dash home" to "Dash Home" lp:924354

To post a comment you must log in.
Revision history for this message
Thomi Richards (thomir-deactivatedaccount) :
review: Approve
Revision history for this message
Omer Akram (om26er) wrote :

before merging this we need design input on this. IIRC it was denied before.

Revision history for this message
Tim Penhey (thumper) wrote :

I'm going to override the pending design on this. To me this makes sense, and adds consistency, not detracts from it.

In fact, it is "Dash Home" in the quicklist.

Although, this is now a string change post freeze. Damn.

review: Approve
Revision history for this message
Tim Penhey (thumper) wrote :

Just noticed that we use "Dash Home" further down the file.

Perhaps we can avoid string freeze by still referring to _("Dash home") somewhere but just not using it. That way the string parser will still find it and not change the .po file.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

We already have a discussion with John on quicklist and other items about it. We agreed that header capitalization has to be used everywhere. (title case name). Approving.

Revision history for this message
Unity Merger (unity-merger) wrote :

No commit message specified.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/unityshell/src/BFBLauncherIcon.cpp'
2--- plugins/unityshell/src/BFBLauncherIcon.cpp 2012-02-08 00:32:46 +0000
3+++ plugins/unityshell/src/BFBLauncherIcon.cpp 2012-02-12 17:36:19 +0000
4@@ -35,7 +35,7 @@
5 BFBLauncherIcon::BFBLauncherIcon()
6 : SimpleLauncherIcon()
7 {
8- tooltip_text = _("Dash home");
9+ tooltip_text = _("Dash Home");
10 icon_name = PKGDATADIR"/launcher_bfb.png";
11 SetQuirk(QUIRK_VISIBLE, true);
12 SetQuirk(QUIRK_RUNNING, false);