Merge ~fourdollars/plainbox-provider-checkbox:master into plainbox-provider-checkbox:master

[Shih-Yuan Lee]

[Jonathan Cave (jocave)]

Could you make _description a little clearer please? I don't think it really explains what the test is checking for.

Something like "Test that Energy Efficient Ethernet (EEE) is enabled on interface {interface} using ethtool" maybe.

Also the estimated_duration seems rather high.

review: Needs Fixing

[Sylvain Pineau (sylvain-pineau)]

the output could also be:

EEE status: enabled - inactive

maybe grepping for 'enabled - active' is what you're looking for?

review: Needs Fixing

[Jonathan Cave (jocave)]

You can also remove the {__index__} template it does not serve any purpose on this test.

[Shih-Yuan Lee (fourdollars)]

I have revised the commit.
Please help to check it again.

[Jonathan Cave (jocave)]

Happy my requests have been fixed, thanks

review: Approve

[Sylvain Pineau (sylvain-pineau)]

+1

review: Approve

diff --git a/units/ethernet/jobs.pxu b/units/ethernet/jobs.pxu
index b31fc15..94dcda3 100644
--- a/units/ethernet/jobs.pxu
+++ b/units/ethernet/jobs.pxu
@@ -129,6 +129,21 @@ _description:
 unit: template
 template-resource: device
 template-filter: device.category == 'NETWORK' and device.interface != 'UNKNOWN'
+plugin: shell
+category_id: com.canonical.plainbox::ethernet
+id: ethernet/ethertool_eee_check_device_{interface}
+_summary: Check ethtool EEE status for NIC {interface}
+estimated_duration: 330.0
+requires:
+ package.name == 'ethtool' or executable.name == 'ethtool'
+user: root
+command: ethtool --show-eee {interface} | grep "EEE status: enabled - active"
+_description:
+ Test that Energy Efficient Ethernet (EEE) is enabled on interface {interface} using ethtool.
+
+unit: template
+template-resource: device
+template-filter: device.category == 'NETWORK' and device.interface != 'UNKNOWN'
 plugin: user-interact-verify
 category_id: com.canonical.plainbox::ethernet
 id: ethernet/maximum_bandwidth_device{__index__}_{interface}