Merge ~fourdollars/pc-enablement/+git/ubuntu-recovery:main into ~oem-solutions-engineers/pc-enablement/+git/ubuntu-recovery:main

Proposed by Shih-Yuan Lee
Status: Merged
Approved by: Shih-Yuan Lee
Approved revision: b69f000c516211afb65b9ea1113cddc4e3081420
Merged at revision: e3505fcb31ddd69e4fbcfa45403f70e878a0d7db
Proposed branch: ~fourdollars/pc-enablement/+git/ubuntu-recovery:main
Merge into: ~oem-solutions-engineers/pc-enablement/+git/ubuntu-recovery:main
Diff against target: 45 lines (+2/-10)
3 files modified
bin/recovery-media-creator (+2/-0)
debian/ubuntu-recovery.postinst (+0/-5)
debian/ubuntu-recovery.templates (+0/-5)
Reviewer Review Type Date Requested Status
Bin Li Approve
Review via email: mp+425219@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Bin Li (binli) wrote :

LGTM.
Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/recovery-media-creator b/bin/recovery-media-creator
2index eb61617..2b6e831 100755
3--- a/bin/recovery-media-creator
4+++ b/bin/recovery-media-creator
5@@ -16,6 +16,8 @@
6 # You should have received a copy of the GNU General Public License
7 # along with this program. If not, see <http://www.gnu.org/licenses/>.
8
9+import gi
10+gi.require_version('Gtk', '3.0')
11 from gi.repository import Gtk, GObject
12 import subprocess, logging, dbus, os
13
14diff --git a/debian/ubuntu-recovery.postinst b/debian/ubuntu-recovery.postinst
15index b0cf7bd..3574e18 100644
16--- a/debian/ubuntu-recovery.postinst
17+++ b/debian/ubuntu-recovery.postinst
18@@ -14,11 +14,6 @@ case "$1" in
19 [ "$RET" != "PQSERVICE" -a -e /lib/udev/rules.d/96-ubuntu-recovery-partition.rules ]; then
20 sed 's/PQSERVICE/'$RET'/g' -i /lib/udev/rules.d/96-ubuntu-recovery-partition.rules
21 fi
22-
23- if db_get ubuntu-recovery/recovery_media && \
24- [ "$RET" = false -a -e /usr/share/applications/recovery-media-creator.desktop ]; then
25- rm /usr/share/applications/recovery-media-creator.desktop
26- fi
27 ;;
28
29 abort-upgrade|abort-remove|abort-deconfigure)
30diff --git a/debian/ubuntu-recovery.templates b/debian/ubuntu-recovery.templates
31index 7d1c088..7978827 100644
32--- a/debian/ubuntu-recovery.templates
33+++ b/debian/ubuntu-recovery.templates
34@@ -47,11 +47,6 @@ Type: string
35 Default: 0
36 Description: for internal use; determines the offset of the recovery partition
37
38-Template: ubuntu-recovery/recovery_media
39-Type: boolean
40-Default: false
41-Description: for internal use; determines the support of creating the recovery media on USB and DVD.
42-
43 Template: ubuntu-recovery/active_partition
44 Type: string
45 Default: dynamic

Subscribers

People subscribed via source and target branches