Merge lp:~fossfreedom/ubiquity/fix_add_ubuntu_budgie_support into lp:ubiquity

Proposed by fossfreedom
Status: Merged
Merged at revision: 6502
Proposed branch: lp:~fossfreedom/ubiquity/fix_add_ubuntu_budgie_support
Merge into: lp:ubiquity
Diff against target: 58 lines (+15/-4)
2 files modified
bin/ubiquity-dm (+9/-4)
debian/changelog (+6/-0)
To merge this branch: bzr merge lp:~fossfreedom/ubiquity/fix_add_ubuntu_budgie_support
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+314267@code.launchpad.net

Description of the change

This adds support for Ubuntu Budgie (LP: #1654368)

To post a comment you must log in.
6503. By fossfreedom

corrected bug report - 1654368

Revision history for this message
Colin Watson (cjwatson) :
review: Approve
6504. By fossfreedom

slightly restructure to reduce code duplication

Revision history for this message
fossfreedom (fossfreedom) wrote :

Many thanks Colin,

  have made those changes requested. Have done a debuild, as well as tested the resulting .debs in a live-session.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/ubiquity-dm'
2--- bin/ubiquity-dm 2016-12-02 14:58:25 +0000
3+++ bin/ubiquity-dm 2017-01-07 10:10:26 +0000
4@@ -492,7 +492,8 @@
5 ('org.mate.background', 'picture-filename',
6 "''"))
7
8- if osextras.find_on_path('gnome-shell'):
9+ if (osextras.find_on_path('gnome-shell') or
10+ osextras.find_on_path('budgie-wm')):
11 gsettings_keys.append(
12 ('org.gnome.settings-daemon.plugins.background',
13 'active', 'false'))
14@@ -551,6 +552,8 @@
15
16 if osextras.find_on_path('gnome-shell'):
17 wm_cmd = ['gnome-shell', '--sm-disable', '--mode=ubiquity']
18+ elif osextras.find_on_path('budgie-wm'):
19+ wm_cmd = ['budgie-wm', '--sm-disable']
20 elif osextras.find_on_path('marco'):
21 wm_cmd = ['marco', '--sm-disable']
22 elif osextras.find_on_path('metacity'):
23@@ -569,8 +572,9 @@
24 else:
25 raise MissingProgramError(
26 'No window manager found (tried '
27- 'marco, metacity, xfwm4, matchbox-window-manager, '
28- 'openbox-lubuntu, openbox, compiz)')
29+ 'gnome-shell, budgie-wm, marco, metacity, xfwm4, '
30+ 'matchbox-window-manager, openbox-lubuntu, '
31+ 'openbox, compiz)')
32
33 wm = subprocess.Popen(
34 wm_cmd, stdin=null, stdout=logfile, stderr=logfile,
35@@ -596,7 +600,8 @@
36 if os.path.exists('/usr/lib/ubiquity/panel'):
37 if ("openbox-lubuntu" not in wm_cmd and
38 "openbox" not in wm_cmd and
39- "gnome-shell" not in wm_cmd):
40+ "gnome-shell" not in wm_cmd and
41+ "budgie-wm" not in wm_cmd):
42 multiarchdir = os.path.split(
43 sysconfig.get_config_var('multiarchsubdir'))[-1]
44 indicators = list(filter(os.path.isfile, [
45
46=== modified file 'debian/changelog'
47--- debian/changelog 2016-12-05 12:39:44 +0000
48+++ debian/changelog 2017-01-07 10:10:26 +0000
49@@ -1,3 +1,9 @@
50+ubiquity (17.04.2) zesty; urgency=medium
51+
52+ * Update ubiquity-dm to support Ubuntu Budgie (LP: #1654368)
53+
54+ -- David Mohammed <fossfreedom@ubuntu.com> Fri, 06 Jan 2017 23:23:30 +0000
55+
56 ubiquity (17.04.1) zesty; urgency=medium
57
58 * Update sources to zesty.

Subscribers

People subscribed via source and target branches

to status/vote changes: