Turku Backup System

Merge lp:~foli/turku/turku-agent into lp:turku/turku-agent

  1. turku-agent
  2. Merge into turku-agent
Proposed by Michael Foley
Status: Rejected
Rejected by: Haw Loeung
Proposed branch: lp:~foli/turku/turku-agent
Merge into: lp:turku/turku-agent
Diff against target: 12 lines (+2/-1)
1 file modified
turku_agent/utils.py (+2/-1)
To merge this branch: bzr merge lp:~foli/turku/turku-agent
Reviewer Review Type Date Requested Status
Haw Loeung Disapprove
Review via email: mp+314964@code.launchpad.net

Commit message

[foli] fix removing source config, LP#1657240

Description of the change

fix removing source config, LP#1657240 (https://bugs.launchpad.net/turku/+bug/1657240)

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Haw Loeung (hloeung) wrote :

Old, rejected.

review: Disapprove

Unmerged revisions

44. By Michael Foley

[foli] fix removing source config, LP#1657240

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'turku_agent/utils.py'
2--- turku_agent/utils.py 2015-05-12 23:46:06 +0000
3+++ turku_agent/utils.py 2017-01-17 20:13:19 +0000
4@@ -208,7 +208,8 @@
5 sources_config = dict_merge(sources_config, json_load_file(file))
6
7 # Check for required sources options
8- for s in sources_config.keys():
9+ sources_config_keys = sources_config.keys()
10+ for s in sources_config_keys:
11 if 'path' not in sources_config[s]:
12 del sources_config[s]
13

Subscribers

People subscribed via source and target branches

to all changes: