ubiquity

Merge lp:~fo0bar/ubiquity/geoname-use-https into lp:ubiquity

  1. geoname-use-https
  2. Merge into trunk
Proposed by Ryan Finnie
Status: Merged
Merged at revision: 6581
Proposed branch: lp:~fo0bar/ubiquity/geoname-use-https
Merge into: lp:ubiquity
Diff against target: 12 lines (+1/-1)
1 file modified
ubiquity/plugins/ubi-timezone.py (+1/-1)
To merge this branch: bzr merge lp:~fo0bar/ubiquity/geoname-use-https
Reviewer Review Type Date Requested Status
Iain Lane Approve
Review via email: mp+335568@code.launchpad.net

Description of the change

geoname-lookup.ubuntu.com allows for HTTPS now; ubiquity should use HTTPS to prevent MITM location information disclosure.

Note that this is for geoname-lookup itself; tzsetup also queries against geoip.ubuntu.com and I will file a separate bug for that.

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubiquity/plugins/ubi-timezone.py'
2--- ubiquity/plugins/ubi-timezone.py 2017-07-18 15:21:41 +0000
3+++ ubiquity/plugins/ubi-timezone.py 2017-12-22 22:30:10 +0000
4@@ -36,7 +36,7 @@
5 AFTER = ['partman', 'language']
6 WEIGHT = 10
7
8-_geoname_url = 'http://geoname-lookup.ubuntu.com/?query=%s&release=%s'
9+_geoname_url = 'https://geoname-lookup.ubuntu.com/?query=%s&release=%s'
10
11
12 class PageGtk(plugin.PluginUI):

Subscribers

People subscribed via source and target branches

to status/vote changes: