Merge lp:~fo0bar/turku/turku-agent-timers-network into lp:turku/turku-agent

Proposed by Ryan Finnie
Status: Merged
Approved by: Haw Loeung
Approved revision: 52
Merged at revision: 54
Proposed branch: lp:~fo0bar/turku/turku-agent-timers-network
Merge into: lp:turku/turku-agent
Diff against target: 27 lines (+8/-0)
2 files modified
turku-agent-ping.timer (+4/-0)
turku-update-config.timer (+4/-0)
To merge this branch: bzr merge lp:~fo0bar/turku/turku-agent-timers-network
Reviewer Review Type Date Requested Status
Haw Loeung +1 Approve
Stuart Bishop (community) Approve
Canonical IS Reviewers Pending
Review via email:

Commit message

Run timers after /

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Stuart Bishop (stub) wrote :

This seems good. I'll have to trust you on the syntax and target names.

review: Approve
Revision history for this message
Haw Loeung (hloeung) :
Revision history for this message
Ryan Finnie (fo0bar) :
52. By Ryan Finnie

Run timers after /

If a machine has been off for more than 5 minutes, turku-agent-ping.timer
will run immediately upon boot, often before network connectivity, and
will fail. This is harmless since it'll just try again 5 minutes later,
but a failure upon boot looks bad. Additionally, the timers will always
run immediately on a machine without an RTC (e.g. Raspberry Pi), so wait
for time-sync.

Revision history for this message
Haw Loeung (hloeung) wrote :

LGTM,... and Hi!

review: Approve (+1)
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 54

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'turku-agent-ping.timer'
--- turku-agent-ping.timer 2018-06-02 23:28:32 +0000
+++ turku-agent-ping.timer 2020-03-24 01:07:14 +0000
@@ -1,5 +1,9 @@
=== modified file 'turku-update-config.timer'
--- turku-update-config.timer 2018-06-02 23:44:51 +0000
+++ turku-update-config.timer 2020-03-24 01:07:14 +0000
@@ -1,5 +1,9 @@


People subscribed via source and target branches

to all changes: