Code review comment for lp:~fo0bar/turku/turku-agent-gonogo

Revision history for this message
Tom Haddon (mthaddon) wrote :

Could you explain a little more about what this change is doing, ideally in the help for the command and comments in the code?

It seems a little confusing to have a variable called "gonogo_program" that's actually a list.

And if I'm understanding this right, this option can be set either via the command line option or via a config option on disk? I'm not entirely sure, but it looks like that's the case from the change to turku_agent/

Looks like there's a fair amount of techdebt here in terms of lack of lint or tests. I don't have enough context on the change to understand whether it makes sense to block on those or have those happen as a separate change. Could you explain why this is needed and what the impact is?

review: Needs Information

« Back to merge proposal