Merge lp:~fnordahl/ubuntu-openstack-ci/fix-zaza-integration into lp:ubuntu-openstack-ci

Proposed by Frode Nordahl
Status: Merged
Merged at revision: 415
Proposed branch: lp:~fnordahl/ubuntu-openstack-ci/fix-zaza-integration
Merge into: lp:ubuntu-openstack-ci
Diff against target: 30 lines (+5/-5)
1 file modified
run/job-parts/osci_openstack_common.sh (+5/-5)
To merge this branch: bzr merge lp:~fnordahl/ubuntu-openstack-ci/fix-zaza-integration
Reviewer Review Type Date Requested Status
Chris MacNaughton (community) Approve
Review via email: mp+364095@code.launchpad.net

Description of the change

This merge proposal addresses two issues:
- Fix a problem with retrieving the commit messages
- Use ``Func-Test-PR`` as header instead of ``Depends-On`` pending resolution of Zuul GitHub integration issues

To post a comment you must log in.
Revision history for this message
Chris MacNaughton (chris.macnaughton) wrote :

Looks reasonable

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'run/job-parts/osci_openstack_common.sh'
2--- run/job-parts/osci_openstack_common.sh 2018-12-13 20:55:35 +0000
3+++ run/job-parts/osci_openstack_common.sh 2019-03-07 14:48:25 +0000
4@@ -136,13 +136,13 @@
5 }
6
7
8-function f_openstack_get_zaza_github_depends_on() {
9+function f_openstack_get_zaza_github_func_test_pr() {
10 f_line $FUNCNAME
11- _pr=$(git -C ${BUILT_ASSET_DIR-$CO_DIR} show | \
12- awk 'tolower($0) ~ /depends-on: .*github.*zaza.*pull/ {print $2; exit;}' | \
13+ _pr=$(git -C ${CO_DIR} show | \
14+ awk 'tolower($0) ~ /func-test-pr: .*github.*zaza.*pull/ {print $2; exit;}' | \
15 rev | cut -sf1,3,4 -d/ | rev)
16 if [ -z "$_pr" ]; then
17- echo "No GitHub Depends-On found..."
18+ echo "No GitHub Func-Test-PR found..."
19 return
20 fi
21 _pr_repo=$(echo $_pr | cut -f1-2 -d/)
22@@ -158,7 +158,7 @@
23
24 function f_openstack_update_zaza_test_requirements() {
25 f_line $FUNCNAME
26- f_openstack_get_zaza_github_depends_on
27+ f_openstack_get_zaza_github_func_test_pr
28 if [ -n "$GITHUB_PR_LOGIN" -a -n "$GITHUB_PR_BRANCH" ]; then
29 sed -i s/openstack-charmers\\/zaza.git/${GITHUB_PR_LOGIN}\\/zaza.git@${GITHUB_PR_BRANCH}/ ${BUILT_ASSET_DIR-$CO_DIR}/test-requirements.txt
30 fi

Subscribers

People subscribed via source and target branches