lp:~fluidity-core/fluidity/low_re_p_correction_fix

Branch merges

Propose for merging

No branches dependent on this one.

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

4141. By Stephan Kramer on 2012-12-11

Hopefully fixing the intel debug build.

For some bizarre reason intel started to choke on a bit of debugging code, code that is perfectly legal and hasn't changed for a long time. However on reading the code I realized the debugging check was actually incorrect. So hopefully fixing that will also placate the intel compiler.

4140. By Cian Wilson on 2012-12-11

Merging in changes from lp:~amcg-stokes/fluidity/multimaterial_diagnostic_dependencies. This changes the behaviour of diagnostic algorithm's dependency search when material_phase support is set to multiple. It now searches across all material_phases for FieldName. The behaviour when material_phase_support is set to single or when StateName::FieldName is given is unchanged. This has been tested using the example of bulk_viscosity under Viscosity which now depends on MaterialViscosity (requires options file that use it to be updated), which is found across all material_phases as it should be.

4139. By Rhodri Davies on 2012-12-10

Remove special test case, which I will shortly add as a long test.

4138. By Stephan Kramer on 2012-12-10

Merging in of the viscous free surface branch.

This implements the free surface algorithm that enforces a no normal stress condition at the free surface, instead of p=0. For more details, see http://dx.doi.org/10.1016/j.pepi.2012.01.001
To use, simply add the no_normal_stress option under the free_surface boundary condition and switch the FreeSurface field from diagnostic to prognostic.
As this is required for testing, this commit also introduces the option to apply remove_null_space seperately for components of a vector solve.

This is a Team Stokes production. Thanks to Simon F. for reviewing.

4137. By Frank Milthaler <<email address hidden>. on 2012-12-08

forgot to change the xml of the example flow_past_sphere_Re1000 in revision 4135. this commit fixes that.

4136. By Stephan Kramer on 2012-12-03

Bug-fix: small inconsistency in memory registration for csr sparsities lead to spurious memory leak reports.

4135. By Frank Milthaler <<email address hidden>. on 2012-11-30

The user is now allowed to define how many body forces they want to compute, whereas one body force could be assembled by 1 or more surface ids in the mesh. The user then gives each body force a unique name, which will be dumped as such in the stat file, e.g. force_uniquebodyforcename%1 is the x component of the body force which has the name uniquebodyforcename.

4134. By Samuel Parkinson on 2012-11-27

Make makefiles updates for previous commit

4133. By Samuel Parkinson on 2012-11-27

Edited the schema to allow specification of the mesh used for sinking velocity fields. This is needed when the velocity field is on a different mesh to the scalar field with the sinking velocity or when using P1DGP2 with a DG field and projecting velocity to continuous.

Also added options checking to ensure the sinking velocity is on the same mesh as the velocity or projected velcoity field and updated relevant tests.

4132. By Mark Filipiak on 2012-11-24

Changes the mesh decomposition tool from fldecomp to flredecomp.

Previously, fldecomp was used for the initial decomposition of a mesh
 before running fluidity and flredecomp was used for re-decomposition
 after a checkpoint. fldecomp is a stand-alone program; flredecomp is
 part of Fluidity, using its input routines and its interface to the
 Zoltan partitioner. Vertex and element re-numbering is being
 developed in Fluidity to improve the NUMA and cache performance.
 Using flredecomp for all mesh decomposition means that the
 re-numbering needs to be implemented in Fluidity only and not in
 fldecomp as well.

Most of the change is simply converting the tests from the fldecomp
 work-flow:

<generate mesh>
 fldecomp -n <nparts> <other options> mesh
 mpiexec -n <nparts> fluidity <other options> sim.flml

to the flredecomp work-flow:

<generate mesh>
 mpiexec -n <nparts> flredecomp -i 1 -o <nparts> sim sim_flredecomp
 mpiexec -n <nparts> fluidity <other options> sim_flredecomp.flml

These changes have been implemented in all of the parallel tests,
 longtests, and examples.

Code changes are:

1/ For spherical meshes, the spatial dimension as well as the
 topological dimension is broadcast by insert_external_mesh
 (Populate_State.F90). Both dimensions are needed in flredecomp.

Users will still have fldecomp in their work-flow, so fldecomp has not
 yet been removed. It now prints a message recommending that the
 decomposition is changed to use flredecomp, and warning that fldecomp
 will be removed in a future release of Fluidity.

flredecomp cannot decompose Terreno meshes, so fldecomp has to be
 retained until any Fluidity simulations using Terreno meshes are
 converted to using the mesh extrusion available in Fluidity.