Merge lp:~flscogna/ubuntu-weather-app/reorganization-and-native-launcher into lp:ubuntu-weather-app/obsolete.trunk
Proposed by
Filippo Scognamiglio
Status: | Rejected |
---|---|
Rejected by: | Daniel Holbach |
Proposed branch: | lp:~flscogna/ubuntu-weather-app/reorganization-and-native-launcher |
Merge into: | lp:ubuntu-weather-app/obsolete.trunk |
Diff against target: |
300 lines (+127/-40) 9 files modified
CMakeLists.txt (+21/-18) debian/control (+7/-6) debian/qtdeclarative5-ubuntuweather-timezone-plugin1.0.install (+1/-1) src/CMakeLists.txt (+2/-0) src/app/CMakeLists.txt (+24/-0) src/app/main.cpp (+66/-0) src/plugins/CMakeLists.txt (+6/-2) ubuntu-weather-app.desktop (+0/-10) ubuntu-weather-app.in (+0/-3) |
To merge this branch: | bzr merge lp:~flscogna/ubuntu-weather-app/reorganization-and-native-launcher |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Needs Fixing | |
Daniel Holbach (community) | Needs Fixing | ||
Nicholas Skaggs (community) | Needs Fixing | ||
Alan Pope πΊπ§π± π¦ | Pending | ||
Review via email: mp+241351@code.launchpad.net |
Commit message
Project reorganization and migration to native launcher.
Description of the change
The project has been reorganized following the terminal as a guideline. The program is now launched from a binary executable (instead of relying on qmlscene) I tested it both on the phone and on the desktop. I really hope everything is in place.
To post a comment you must log in.
Unmerged revisions
- 391. By Filippo Scognamiglio
-
Merge changes from dholbach.
- 390. By Filippo Scognamiglio
-
Fix names and removes unused files.
- 389. By Filippo Scognamiglio
-
Fix a couple of issues in desktop building.
- 388. By Filippo Scognamiglio
-
Project reorganization and migration to native launcher.
FAILED: Continuous integration, rev:388 91.189. 93.70:8080/ job/ubuntu- weather- app-ci/ 298/ 91.189. 93.70:8080/ job/generic- mediumtests- vivid-weather- app/8/console 91.189. 93.70:8080/ job/ubuntu- weather- app-vivid- amd64-ci/ 6/console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/ubuntu- weather- app-ci/ 298/rebuild
http://