Code review comment for lp:~flscogna/ubuntu-terminal-app/json-keyboard-profiles

Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

LGTM, good work Filippo!

However, as discussed on Hangouts, the only thing that could be improved is the way you get the ConfigLocation from QStandardPaths.

Some of the returning paths are confined by the AppArmor policies, so it may be worth to use QStandardPaths::writableLocation(QStandardPaths::ConfigLocation) which, according to Qt docs[1], "returns the directory where files of type should be written to".

Tested on utopic desktop.

[1]: http://doc.qt.io/qt-5/qstandardpaths.html#standardLocations

review: Approve

« Back to merge proposal