Ubuntu Terminal App

Merge lp:~flscogna/ubuntu-terminal-app/delete-tests into lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

  1. delete-tests
  2. Merge into reboot
Proposed by Filippo Scognamiglio on 2015-02-24
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 🦄 on 2015-02-26
Approved revision: 59
Merged at revision: 54
Proposed branch: lp:~flscogna/ubuntu-terminal-app/delete-tests
Merge into: lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target: 85 lines (+56/-0)
5 files modified
tests/CMakeLists.txt (+1/-0)
tests/autopilot/CMakeLists.txt (+8/-0)
tests/autopilot/ubuntu_terminal_app/__init__.py (+19/-0)
tests/autopilot/ubuntu_terminal_app/tests/__init__.py (+10/-0)
tests/autopilot/ubuntu_terminal_app/tests/test_terminal.py (+18/-0)
To merge this branch: bzr merge lp:~flscogna/ubuntu-terminal-app/delete-tests
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 🦄 Approve on 2015-02-26
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve on 2015-02-25
Nicholas Skaggs 2015-02-24 Needs Fixing on 2015-02-25
Review via email: mp+250848@code.launchpad.net

Commit Message

Delete the pre-reboot tests.

Description of the Change

Delete the pre-reboot tests (but keep a copy for future reference).

To post a comment you must log in.
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
lp:~flscogna/ubuntu-terminal-app/delete-tests updated on 2015-02-24
55. By Filippo Scognamiglio on 2015-02-24

Remove empty line at the end of test_terminal.py

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
lp:~flscogna/ubuntu-terminal-app/delete-tests updated on 2015-02-25
56. By Filippo Scognamiglio on 2015-02-25

Remove unused python imports.

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Nicholas Skaggs (nskaggs) wrote :

Filippo, you will need at least one testcase for this to work. You can make some stub testcases if you wish if you are not ready to yet write the testcase.

def test_blah_blah(self):
# """Blah must do blah when I push the blah button"""
    pass

It would be really helpful to add descriptive testcase stubs like this and then file a bug for them to be worked. You can see an example of this here: https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1425267. Remember to tag the bug with needs-autopilot-test so it shows up in the big list :-)

review: Needs Fixing
lp:~flscogna/ubuntu-terminal-app/delete-tests updated on 2015-02-25
57. By Filippo Scognamiglio on 2015-02-25

Add dummy autopilot test.

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
lp:~flscogna/ubuntu-terminal-app/delete-tests updated on 2015-02-25
58. By Filippo Scognamiglio on 2015-02-25

Fix C++ habits.

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
lp:~flscogna/ubuntu-terminal-app/delete-tests updated on 2015-02-25
59. By Filippo Scognamiglio on 2015-02-25

Fix pep8 python issues.

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== renamed directory 'tests' => 'old-tests'
2=== added directory 'tests'
3=== added file 'tests/CMakeLists.txt'
4--- tests/CMakeLists.txt 1970-01-01 00:00:00 +0000
5+++ tests/CMakeLists.txt 2015-02-25 18:37:50 +0000
6@@ -0,0 +1,1 @@
7+add_subdirectory(autopilot)
8
9=== added directory 'tests/autopilot'
10=== added file 'tests/autopilot/CMakeLists.txt'
11--- tests/autopilot/CMakeLists.txt 1970-01-01 00:00:00 +0000
12+++ tests/autopilot/CMakeLists.txt 2015-02-25 18:37:50 +0000
13@@ -0,0 +1,8 @@
14+if(INSTALL_TESTS)
15+execute_process(COMMAND python3 -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())"
16+ OUTPUT_VARIABLE PYTHON_PACKAGE_DIR OUTPUT_STRIP_TRAILING_WHITESPACE)
17+
18+install(DIRECTORY ${AUTOPILOT_DIR}
19+ DESTINATION ${PYTHON_PACKAGE_DIR}
20+ )
21+endif(INSTALL_TESTS)
22
23=== added directory 'tests/autopilot/ubuntu_terminal_app'
24=== added file 'tests/autopilot/ubuntu_terminal_app/__init__.py'
25--- tests/autopilot/ubuntu_terminal_app/__init__.py 1970-01-01 00:00:00 +0000
26+++ tests/autopilot/ubuntu_terminal_app/__init__.py 2015-02-25 18:37:50 +0000
27@@ -0,0 +1,19 @@
28+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
29+#
30+# Copyright (C) 2013 Canonical Ltd.
31+#
32+# This program is free software; you can redistribute it and/or modify
33+# it under the terms of the GNU Lesser General Public License as published by
34+# the Free Software Foundation; version 3.
35+#
36+# This program is distributed in the hope that it will be useful,
37+# but WITHOUT ANY WARRANTY; without even the implied warranty of
38+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
39+# GNU Lesser General Public License for more details.
40+#
41+# You should have received a copy of the GNU Lesser General Public License
42+# along with this program. If not, see <http://www.gnu.org/licenses/>.
43+
44+"""Terminal app autopilot helpers."""
45+
46+# TODO Insert new tests here
47
48=== added directory 'tests/autopilot/ubuntu_terminal_app/tests'
49=== added file 'tests/autopilot/ubuntu_terminal_app/tests/__init__.py'
50--- tests/autopilot/ubuntu_terminal_app/tests/__init__.py 1970-01-01 00:00:00 +0000
51+++ tests/autopilot/ubuntu_terminal_app/tests/__init__.py 2015-02-25 18:37:50 +0000
52@@ -0,0 +1,10 @@
53+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
54+# Copyright 2013 Canonical
55+#
56+# This program is free software: you can redistribute it and/or modify it
57+# under the terms of the GNU General Public License version 3, as published
58+# by the Free Software Foundation.
59+
60+"""Terminal app autopilot tests."""
61+
62+# TODO Insert new tests here.
63
64=== added file 'tests/autopilot/ubuntu_terminal_app/tests/test_terminal.py'
65--- tests/autopilot/ubuntu_terminal_app/tests/test_terminal.py 1970-01-01 00:00:00 +0000
66+++ tests/autopilot/ubuntu_terminal_app/tests/test_terminal.py 2015-02-25 18:37:50 +0000
67@@ -0,0 +1,18 @@
68+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
69+# Copyright 2013 Canonical
70+#
71+# This program is free software: you can redistribute it and/or modify it
72+# under the terms of the GNU General Public License version 3, as published
73+# by the Free Software Foundation.
74+
75+"""Terminal app autopilot tests."""
76+
77+from autopilot.testcase import AutopilotTestCase
78+
79+# TODO Insert new tests here.
80+
81+
82+class DummyTest(AutopilotTestCase):
83+ """This is just a placeholder test"""
84+ def test_dummy_true(self):
85+ self.assertTrue(True)

Subscribers

People subscribed via source and target branches