Merge lp:~florin9doi/terminator/terminator into lp:terminator/gtk3

Proposed by Florin9doi
Status: Needs review
Proposed branch: lp:~florin9doi/terminator/terminator
Merge into: lp:terminator/gtk3
Diff against target: 56 lines (+28/-0)
2 files modified
terminatorlib/preferences.glade (+20/-0)
terminatorlib/prefseditor.py (+8/-0)
To merge this branch: bzr merge lp:~florin9doi/terminator/terminator
Reviewer Review Type Date Requested Status
Terminator Pending
Review via email: mp+357868@code.launchpad.net

Commit message

Add a checkbox in prefseditor for suppress_multiple_term_dialog.

Description of the change

Add a checkbox in prefseditor for suppress_multiple_term_dialog.
If suppress_multiple_term_dialog is enabled accidentally, there is no trivial way to disable it.

To post a comment you must log in.

Unmerged revisions

1808. By Florin9doi <email address hidden>

Add checkbox to enable/disable suppress_multiple_term_dialog

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'terminatorlib/preferences.glade'
2--- terminatorlib/preferences.glade 2016-12-13 21:08:02 +0000
3+++ terminatorlib/preferences.glade 2018-10-26 08:23:40 +0000
4@@ -552,6 +552,26 @@
5 <property name="width">2</property>
6 </packing>
7 </child>
8+ <child>
9+ <object class="GtkCheckButton" id="multipletermcheck">
10+ <property name="label" translatable="yes">Supress Multiple Term Close Dialog</property>
11+ <property name="tooltip_text" translatable="yes">Disabled – multiple terminals are closed after confirmation
12+Enabled – multiple terminals are closed with no confirmation</property>
13+ <property name="use_action_appearance">False</property>
14+ <property name="visible">True</property>
15+ <property name="can_focus">True</property>
16+ <property name="receives_default">False</property>
17+ <property name="xalign">0.5</property>
18+ <property name="active">True</property>
19+ <property name="draw_indicator">True</property>
20+ <signal name="toggled" handler="on_multipletermcheck_toggled" swapped="no"/>
21+ </object>
22+ <packing>
23+ <property name="left_attach">0</property>
24+ <property name="top_attach">7</property>
25+ <property name="width">2</property>
26+ </packing>
27+ </child>
28 </object>
29 <packing>
30 <property name="expand">True</property>
31
32=== modified file 'terminatorlib/prefseditor.py'
33--- terminatorlib/prefseditor.py 2017-06-24 02:02:38 +0000
34+++ terminatorlib/prefseditor.py 2018-10-26 08:23:40 +0000
35@@ -295,6 +295,9 @@
36 # DBus Server
37 widget = guiget('dbuscheck')
38 widget.set_active(self.config['dbus'])
39+ # Supress Multiple Term Close Dialog
40+ widget = guiget('multipletermcheck')
41+ widget.set_active(self.config['suppress_multiple_term_dialog'])
42 #Hide from taskbar
43 widget = guiget('hidefromtaskbcheck')
44 widget.set_active(self.config['hide_from_taskbar'])
45@@ -695,6 +698,11 @@
46 self.config['dbus'] = widget.get_active()
47 self.config.save()
48
49+ def on_multipletermcheck_toggled(self, widget):
50+ """Supress Multiple Term Close Dialog setting changed"""
51+ self.config['suppress_multiple_term_dialog'] = widget.get_active()
52+ self.config.save()
53+
54 def on_winbordercheck_toggled(self, widget):
55 """Window border setting changed"""
56 self.config['borderless'] = not widget.get_active()

Subscribers

People subscribed via source and target branches

to status/vote changes: