Merge lp:~florian-dacosta/banking-addons/bank-statement-reconcile-7.0_base_import_handle_xlsx_files into lp:banking-addons/bank-statement-reconcile-70
Proposed by
Florian da Costa
Status: | Merged |
---|---|
Approved by: | Yannick Vaucher @ Camptocamp |
Approved revision: | 119 |
Merged at revision: | 132 |
Proposed branch: | lp:~florian-dacosta/banking-addons/bank-statement-reconcile-7.0_base_import_handle_xlsx_files |
Merge into: | lp:banking-addons/bank-statement-reconcile-70 |
Diff against target: |
60 lines (+8/-8) 1 file modified
account_statement_base_import/parser/file_parser.py (+8/-8) |
To merge this branch: | bzr merge lp:~florian-dacosta/banking-addons/bank-statement-reconcile-7.0_base_import_handle_xlsx_files |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Guewen Baconnier @ Camptocamp | Approve | ||
Frederic Clementi - Camptocamp | functional | Approve | |
Joël Grand-Guillaume @ camptocamp | Pending | ||
Review via email: mp+205981@code.launchpad.net |
Description of the change
I noticed the module account_
So I would like the file_parser to handle also the xlsx files.
Basically, I just changed 2 lines in the __init__ function of the parser.
If the file is xlsx, I put xls in the ftype variable so the parser act as if it is a xls file.
I tried an xlsx import this way and it worked great.
I did it this way in order to do the less changes possible, but I am not sure this is the right way...
What do you think?
To post a comment you must log in.
Make sens :)