Merge lp:~florent.x/openerp-client-lib/trunk-imp01 into lp:openerp-client-lib

[Florent]

More efficient Model.__getattr__.

[Nicolas Vanhoren (OpenERP) (niv-openerp)]

It's not that it's bad, but your code does not bring anything. It does not solve any bug, it does not have a better complexity,... it's just a little bit different but does exactly the same.

But I don't want to replace a well-tested code by something else that is exactly the same except it is not well-tested, so I have to refuse.

review: Disapprove

[Florent (florent.x)]

I agree the alternative dict() construct does not bring any perf benefit.

Maybe you want to do only the two simple changes:
 - merge the 2 "if" in a single condition
 - replace expression "if len(result) > 0" with "if result"

Unmerged revisions

46. By Florent on 2012-01-19

[imp] improve Model.__getattr__.

=== modified file 'openerplib/main.py'
--- openerplib/main.py	2012-01-09 09:19:06 +0000
+++ openerplib/main.py	2012-01-19 10:37:25 +0000
@@ -248,12 +248,9 @@
                                                     self.model_name,
                                                     method,
                                                     args, kw)
-            if method == "read":
-                if isinstance(result, list) and len(result) > 0 and "id" in result[0]:
-                    index = {}
-                    for r in result:
-                        index[r['id']] = r
-                    result = [index[x] for x in args[0] if x in index]
+            if method == 'read' and result and isinstance(result, list) and 'id' in result[0]:
+                index = dict((r['id'], r) for r in result)
+                result = [index[rid] for rid in args[0] if rid in index]
             self.__logger.debug('result: %r', result)
             return result
         return proxy