GNU Mailman REST Client

Code review comment for lp:~flo-fuchs/mailman.client/settings

  1. settings
  2. Merge into trunk
Revision history for this message
Barry Warsaw (barry) wrote :

This looks great; a couple of comments:

* See above for recommendations against u'' strings and for using print instead of returning strings directly in doctests.

* Could you please open a bug (tagged with 'mailman3') on the need to expose an API call to look up a member-id given an email address? I'll make sure to expose that in a8.

With the above consideration, I'll approve this change. Thanks! And feel free to land it.

review: Approve

« Back to merge proposal