Merge lp:~flexiondotorg/ubuntu-themes/xenial-icon-dim-lp1578810 into lp:ubuntu-themes/xenial

[Martin Wimpress ]

This merge proposal fixes dimming of insensitive icons.

  * https://bugs.launchpad.net/ubuntu/+source/ubuntu-themes/+bug/1578810

Install `gtk-3-examples` and run `gtk3-widget-factory`, look at the toolbar on Page 2, the last icon (tooltip 'Insert something') is disabled and should be dimmed, but is not. After applying this merge proposal disabled icons are dimmed.

I have also reproduced this issue using:

  * Remmina (from the archive)
  * Wireshark (from the archive)
  * Eclipse (downloaded)

To reproduce with eclipse it has to be downloaded since the version in the archive uses GTK2+ for styling, and dims insensitive icons correctly.

[Iain Lane (laney)]

I think this is the same as https://code.launchpad.net/~malaperle/ubuntu-themes/ubuntu-themes/+merge/294568 which came earlier, and we dropped the ball on reviewing.

Sorry :(

review: Disapprove

[Roland Lohner (loczaj)]

Thanks Martin. The patch solved the problem of undimmed buttons in Eclipse Neon.

Unmerged revisions

485. By Martin Wimpress  on 2016-10-14

Add -gtk-image-effect: dim; to insensitive icons. (LP: #1578810)

=== modified file 'Ambiance/gtk-3.0/gtk-widgets.css'
--- Ambiance/gtk-3.0/gtk-widgets.css	2016-07-07 14:08:37 +0000
+++ Ambiance/gtk-3.0/gtk-widgets.css	2016-10-14 08:34:29 +0000
@@ -2118,6 +2118,7 @@
 *:insensitive {
     color: shade (@bg_color, 0.6);
     text-shadow: 0 1px alpha (shade (@bg_color, 1.25), 0.5);
+    -gtk-image-effect: dim;
 }
 
 *:selected,

=== modified file 'Radiance/gtk-3.0/gtk-widgets.css'
--- Radiance/gtk-3.0/gtk-widgets.css	2016-07-07 14:08:37 +0000
+++ Radiance/gtk-3.0/gtk-widgets.css	2016-10-14 08:34:29 +0000
@@ -2132,6 +2132,7 @@
 *:insensitive {
     color: shade (@bg_color, 0.6);
     text-shadow: 0 1px alpha (shade (@bg_color, 1.25), 0.5);
+    -gtk-image-effect: dim;
 }
 
 *:selected,