Merge lp:~flexiondotorg/ubuntu-themes/xenial-icon-dim-lp1578810 into lp:ubuntu-themes/xenial
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Iain Lane | ||||
Proposed branch: | lp:~flexiondotorg/ubuntu-themes/xenial-icon-dim-lp1578810 | ||||
Merge into: | lp:ubuntu-themes/xenial | ||||
Diff against target: |
23 lines (+2/-0) 2 files modified
Ambiance/gtk-3.0/gtk-widgets.css (+1/-0) Radiance/gtk-3.0/gtk-widgets.css (+1/-0) |
||||
To merge this branch: | bzr merge lp:~flexiondotorg/ubuntu-themes/xenial-icon-dim-lp1578810 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Iain Lane | Disapprove | ||
Review via email: mp+308481@code.launchpad.net |
Description of the change
This merge proposal fixes dimming of insensitive icons.
* https:/
Install `gtk-3-examples` and run `gtk3-widget-
I have also reproduced this issue using:
* Remmina (from the archive)
* Wireshark (from the archive)
* Eclipse (downloaded)
To reproduce with eclipse it has to be downloaded since the version in the archive uses GTK2+ for styling, and dims insensitive icons correctly.
Unmerged revisions
- 485. By Martin Wimpress
-
Add -gtk-image-effect: dim; to insensitive icons. (LP: #1578810)
I think this is the same as https:/ /code.launchpad .net/~malaperle /ubuntu- themes/ ubuntu- themes/ +merge/ 294568 which came earlier, and we dropped the ball on reviewing.
Sorry :(