Merge lp:~flexiondotorg/aptdaemon/aptdaemon-lp1623856 into lp:aptdaemon

Proposed by Martin Wimpress on 2016-11-02
Status: Merged
Approved by: Barry Warsaw on 2017-01-19
Approved revision: 987
Merged at revision: 987
Proposed branch: lp:~flexiondotorg/aptdaemon/aptdaemon-lp1623856
Merge into: lp:aptdaemon
Diff against target: 11 lines (+1/-0)
1 file modified
aptdaemon/gtk3widgets.py (+1/-0)
To merge this branch: bzr merge lp:~flexiondotorg/aptdaemon/aptdaemon-lp1623856
Reviewer Review Type Date Requested Status
Barry Warsaw 2016-11-02 Approve on 2016-11-09
Review via email: mp+309871@code.launchpad.net

Commit message

Set a minimum content height of 200px for the download scrolled window. LP: #1623856

Description of the change

Set a minimum content height of 200px for the download scrolled window. This was the default height gtk3widgets used in GTK versions prior to 3.20. (LP: #1623856)

To post a comment you must log in.
Barry Warsaw (barry) wrote :

Although untested, I can confirm the original bug report, and this fix looks reasonable.

review: Approve
arve svepstad (arve-svepstad) wrote :

What is this?

2017-01-23 23:47 GMT+01:00 <email address hidden>:

> The proposal to merge lp:~flexiondotorg/aptdaemon/aptdaemon-lp1623856
> into lp:aptdaemon has been updated.
>
> Status: Approved => Merged
>
> For more details, see:
> https://code.launchpad.net/~flexiondotorg/aptdaemon/
> aptdaemon-lp1623856/+merge/309871
> --
> You are subscribed to branch lp:aptdaemon.
>

Barry Warsaw (barry) wrote :

On Feb 09, 2017, at 09:09 AM, arve svepstad wrote:

>What is this?

I'm not sure what the "this" is that you're asking about. If it's the email,
then that's just a standard Launchpad merge notification. If it's a question
about this specific merge, have you seen LP: #1623856?

https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/1623856

>2017-01-23 23:47 GMT+01:00 <email address hidden>:
>
>> The proposal to merge lp:~flexiondotorg/aptdaemon/aptdaemon-lp1623856
>> into lp:aptdaemon has been updated.
>>
>> Status: Approved => Merged
>>
>> For more details, see:
>> https://code.launchpad.net/~flexiondotorg/aptdaemon/
>> aptdaemon-lp1623856/+merge/309871
>> --
>> You are subscribed to branch lp:aptdaemon.
>>
>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'aptdaemon/gtk3widgets.py'
2--- aptdaemon/gtk3widgets.py 2014-11-10 18:03:20 +0000
3+++ aptdaemon/gtk3widgets.py 2016-11-02 16:59:03 +0000
4@@ -338,6 +338,7 @@
5 self.download_scrolled.set_policy(Gtk.PolicyType.NEVER,
6 Gtk.PolicyType.AUTOMATIC)
7 self.download_scrolled.add(self.download_view)
8+ self.download_scrolled.set_min_content_height(200)
9 hbox = Gtk.HBox()
10 hbox.pack_start(self.download_scrolled, True, True, 0)
11 if self.terminal:

Subscribers

People subscribed via source and target branches

to status/vote changes: