MAAS

Merge lp:~flacoste/maas/death-to-spurious-tests into lp:~maas-committers/maas/trunk

  1. death-to-spurious-tests
  2. Merge into trunk
Proposed by Francis J. Lacoste
Status: Merged
Approved by: Gavin Panella
Approved revision: no longer in the source branch.
Merged at revision: 346
Proposed branch: lp:~flacoste/maas/death-to-spurious-tests
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 20 lines (+4/-0)
1 file modified
src/maasserver/static/js/tests/test_node_views.js (+4/-0)
To merge this branch: bzr merge lp:~flacoste/maas/death-to-spurious-tests
Reviewer Review Type Date Requested Status
Francis J. Lacoste (community) Approve
Review via email: mp+99024@code.launchpad.net

Commit message

Disable timing-sensitive assertion to work-around bug 963090.

To post a comment you must log in.
Revision history for this message
Francis J. Lacoste (flacoste) wrote :

Self-review

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

No approved revision specified.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/maasserver/static/js/tests/test_node_views.js'
2--- src/maasserver/static/js/tests/test_node_views.js 2012-03-21 15:03:08 +0000
3+++ src/maasserver/static/js/tests/test_node_views.js 2012-03-23 13:53:18 +0000
4@@ -233,12 +233,16 @@
5 1,
6 view.chart.get('added_nodes'),
7 'The old chart status number should also be updated');
8+ /* XXX: Bug: 963090 This is timing dependant and causes spurious
9+ failures from time to time.
10+
11 this.wait(function() {
12 Y.Assert.areEqual(
13 Y.one('#nodes-number').get('text'),
14 '12',
15 'The total number of nodes should not have been updated');
16 }, 500);
17+ */
18 },
19
20 testUpdateNodeDeleting: function() {