Merge lp:~flacoste/launchpad/bug-781993-2 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Francis J. Lacoste |
Approved revision: | no longer in the source branch. |
Merged at revision: | 13263 |
Proposed branch: | lp:~flacoste/launchpad/bug-781993-2 |
Merge into: | lp:launchpad |
Prerequisite: | lp:~flacoste/launchpad/bug-781993-1 |
Diff against target: |
249 lines (+85/-16) 7 files modified
lib/lp/bugs/browser/bugtarget.py (+11/-0) lib/lp/bugs/browser/tests/bug-views.txt (+9/-6) lib/lp/bugs/browser/tests/test_bugtarget_filebug.py (+32/-0) lib/lp/bugs/model/bug.py (+2/-6) lib/lp/registry/interfaces/distribution.py (+6/-2) lib/lp/registry/model/distribution.py (+13/-2) lib/lp/registry/tests/test_distribution.py (+12/-0) |
To merge this branch: | bzr merge lp:~flacoste/launchpad/bug-781993-2 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+65058@code.launchpad.net |
Commit message
[r=bac][bug=781993] Allow filing bugs against source package with an official package branch.
Description of the change
= Summary =
We want to be able to file bugs in the Ensemble Principia distribution
(https:/
source package, but they have official source package branch.
It builds on the previous guessPublishedS
== Proposed fix ==
Allow filing a bug on a source package if it has official source package
branch.
== Pre-implementation notes ==
== Implementation details ==
* If no published source package is found, it looks for official source
package branches for it.
== Tests ==
In addition to the unit test for guessPublishedS
integration test just to make sure that we don't regress that functionality.
(By changing the vocabulary for example, they are currently very lax and will
allow any valid source or binary package names. If we were to make them more
context sensitive, it might be a problem if official package branches weren't
considered.)
./bin/test -vvt 'test_guessPubl
== Demo and Q/A ==
Try filing a sourcepackage bug on qastaging on the the principia distribution.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/canonical
lib/lp/
lib/lp/
lib/lp/
lib/lp/
cronscripts/
lib/lp/
lib/lp/
lib/lp/
lib/canonical
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
./lib/lp/
195: source has trailing whitespace.
./lib/lp/
52: 'SQLRaw' imported but unused
52: 'Join' imported but unused
52: 'Exists' imported but unused
171: 'get_bug_
52: 'Count' imported but unused
304: E301 expected 1 blank line, found 0
2590: E225 missing whitespace around operator
./cronscripts/
9: '_pythonpath' imported but unused
./lib/lp/
8: Line exceeds 78 characters.
I'll fix this post-review.
This branch looks good Francis.