Merge lp:~fjkong/gedit/ubuntu into lp:~ubuntu-desktop/gedit/ubuntu

Proposed by FanJun Kong - ( BH1SCW )
Status: Merged
Approved by: Iain Lane
Approved revision: 214
Merged at revision: 214
Proposed branch: lp:~fjkong/gedit/ubuntu
Merge into: lp:~ubuntu-desktop/gedit/ubuntu
Diff against target: 281 lines (+15/-205)
6 files modified
debian/changelog (+9/-0)
debian/control (+3/-3)
debian/control.in (+3/-3)
debian/patches/git_revert_gtk322.patch (+0/-42)
debian/patches/git_revert_gtksourceview322.patch (+0/-155)
debian/patches/series (+0/-2)
To merge this branch: bzr merge lp:~fjkong/gedit/ubuntu
Reviewer Review Type Date Requested Status
Iain Lane Approve
Review via email: mp+309839@code.launchpad.net

Description of the change

  * Remove two patches: git_revert_gtk322.patch
                        git_revert_gtksourceview322.patch
      + libgtk-3-dev (>= 3.21.3)
      + libgtksourceview-3.0-dev (>= 3.21.2)

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

Thanks!

I just reworded the changelog a little bit - please see the branch.

Uploading now

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2016-09-18 20:39:11 +0000
3+++ debian/changelog 2016-11-02 11:42:07 +0000
4@@ -1,3 +1,12 @@
5+gedit (3.22.0-1ubuntu2) zesty; urgency=medium
6+
7+ * Remove two patches: git_revert_gtk322.patch
8+ git_revert_gtksourceview322.patch
9+ + libgtk-3-dev (>= 3.21.3)
10+ + libgtksourceview-3.0-dev (>= 3.21.2)
11+
12+ -- FJKong <fanjun.kong@canonical.com> Sat, 29 Oct 2016 04:04:52 +0800
13+
14 gedit (3.22.0-1ubuntu1) yakkety; urgency=medium
15
16 * Merge with Debian. Remaining changes:
17
18=== modified file 'debian/control'
19--- debian/control 2016-09-18 20:37:48 +0000
20+++ debian/control 2016-11-02 11:42:07 +0000
21@@ -18,8 +18,8 @@
22 libgspell-1-dev (>= 0.2.5),
23 libxml2-dev (>= 2.5.0),
24 libglib2.0-dev (>= 2.44),
25- libgtk-3-dev (>= 3.19.0),
26- libgtksourceview-3.0-dev (>= 3.19.4),
27+ libgtk-3-dev (>= 3.21.3),
28+ libgtksourceview-3.0-dev (>= 3.21.2),
29 libpeas-dev (>= 1.14.1),
30 libx11-dev,
31 python3 (>= 3.2.3),
32@@ -90,7 +90,7 @@
33 Depends: ${misc:Depends},
34 gedit (>= ${gnome:Version}),
35 gedit (<< ${gnome:NextVersion}),
36- libgtksourceview-3.0-dev (>= 3.19.4),
37+ libgtksourceview-3.0-dev (>= 3.21.2),
38 libpeas-dev (>= 1.14.1)
39 Description: official text editor of the GNOME desktop environment (development files)
40 gedit is a text editor which supports most standard editor features,
41
42=== modified file 'debian/control.in'
43--- debian/control.in 2016-09-18 20:37:48 +0000
44+++ debian/control.in 2016-11-02 11:42:07 +0000
45@@ -14,8 +14,8 @@
46 libgspell-1-dev (>= 0.2.5),
47 libxml2-dev (>= 2.5.0),
48 libglib2.0-dev (>= 2.44),
49- libgtk-3-dev (>= 3.19.0),
50- libgtksourceview-3.0-dev (>= 3.19.4),
51+ libgtk-3-dev (>= 3.21.3),
52+ libgtksourceview-3.0-dev (>= 3.21.2),
53 libpeas-dev (>= 1.14.1),
54 libx11-dev,
55 python3 (>= 3.2.3),
56@@ -86,7 +86,7 @@
57 Depends: ${misc:Depends},
58 gedit (>= ${gnome:Version}),
59 gedit (<< ${gnome:NextVersion}),
60- libgtksourceview-3.0-dev (>= 3.19.4),
61+ libgtksourceview-3.0-dev (>= 3.21.2),
62 libpeas-dev (>= 1.14.1)
63 Description: official text editor of the GNOME desktop environment (development files)
64 gedit is a text editor which supports most standard editor features,
65
66=== removed file 'debian/patches/git_revert_gtk322.patch'
67--- debian/patches/git_revert_gtk322.patch 2016-09-18 20:37:48 +0000
68+++ debian/patches/git_revert_gtk322.patch 1970-01-01 00:00:00 +0000
69@@ -1,42 +0,0 @@
70-From d4918b70e76604c77abf43f8b9f708e632ca675f Mon Sep 17 00:00:00 2001
71-From: Olivier Fourdan <ofourdan@redhat.com>
72-Date: Mon, 29 Aug 2016 10:08:43 +0200
73-Subject: gedit-open-document-selector: Add max-content-height
74-
75-This is an (intentional) behavior change in GtkScrolledWindow, without
76-this, the scrolled window can grow without limits and exceed the
77-supported size of a texture.
78-
79-https://bugzilla.gnome.org/show_bug.cgi?id=770430
80----
81- gedit/gedit-open-document-selector.c | 2 ++
82- 1 file changed, 2 insertions(+)
83-
84-diff --git a/configure.ac b/configure.ac
85-index da64884..e90cd33 100644
86---- a/configure.ac
87-+++ b/configure.ac
88-@@ -18,7 +18,7 @@ AC_SUBST(GEDIT_API_VERSION)
89-
90- # Dependencies
91- GLIB_REQUIRED=2.44
92--GTK_REQUIRED=3.21.3
93-+GTK_REQUIRED=3.19.0
94- GTKSOURCEVIEW_REQUIRED=3.21.2
95- LIBPEAS_REQUIRED=1.14.1
96- LIBXML_REQUIRED=2.5.0
97-diff --git a/gedit/gedit-open-document-selector.c b/gedit/gedit-open-document-selector.c
98-index 77075cd..1221d33 100644
99---- a/gedit/gedit-open-document-selector.c
100-+++ b/gedit/gedit-open-document-selector.c
101-@@ -1053,8 +1053,6 @@ on_treeview_allocate (GtkWidget *widget G_GNUC_UNUSED,
102- treeview_height = row_height * limit_capped;
103- gtk_scrolled_window_set_min_content_height (GTK_SCROLLED_WINDOW (selector->scrolled_window),
104- treeview_height);
105-- gtk_scrolled_window_set_max_content_height (GTK_SCROLLED_WINDOW (selector->scrolled_window),
106-- treeview_height);
107-
108- gtk_widget_set_size_request (selector->placeholder_box, -1, treeview_height);
109- }
110---
111-cgit v0.12
112
113=== removed file 'debian/patches/git_revert_gtksourceview322.patch'
114--- debian/patches/git_revert_gtksourceview322.patch 2016-09-06 16:47:19 +0000
115+++ debian/patches/git_revert_gtksourceview322.patch 1970-01-01 00:00:00 +0000
116@@ -1,155 +0,0 @@
117-From dc41eb699946f861d948435c3eb20aa30095b4e8 Mon Sep 17 00:00:00 2001
118-From: =?UTF-8?q?S=C3=A9bastien=20Wilmet?= <swilmet@gnome.org>
119-Date: Sat, 4 Jun 2016 17:49:41 +0200
120-Subject: search: use gtk_source_search_context_replace2()
121-
122-gtk_source_search_context_replace() is deprecated.
123----
124- README | 2 +-
125- configure.ac | 2 +-
126- gedit/gedit-commands-search.c | 12 ++++++------
127- 3 files changed, 8 insertions(+), 8 deletions(-)
128-
129-Index: gedit-3.21.90/README
130-===================================================================
131---- gedit-3.21.90.orig/README
132-+++ gedit-3.21.90/README
133-@@ -64,7 +64,7 @@ Information about gedit mailing lists ca
134- Installation
135- ============
136-
137--gedit requires GTK+ >= 3.20.0, GtkSourceView >= 3.21.2 and
138-+gedit requires GTK+ >= 3.20.0, GtkSourceView >= 3.20.0 and
139- libpeas >= 1.14.1 libraries. It also has a run-time dependency on an
140- icon theme for its icons. If gedit fails to display icons, installing
141- GNOME's default adwaita-icon-theme is a simple way of providing them.
142-Index: gedit-3.21.90/configure.ac
143-===================================================================
144---- gedit-3.21.90.orig/configure.ac
145-+++ gedit-3.21.90/configure.ac
146-@@ -19,7 +19,7 @@ AC_SUBST(GEDIT_API_VERSION)
147- # Dependencies
148- GLIB_REQUIRED=2.44
149- GTK_REQUIRED=3.19.0
150--GTKSOURCEVIEW_REQUIRED=3.21.2
151-+GTKSOURCEVIEW_REQUIRED=3.19.4
152- LIBPEAS_REQUIRED=1.14.1
153- LIBXML_REQUIRED=2.5.0
154- GSPELL_REQUIRED=0.2.5
155-Index: gedit-3.21.90/gedit/gedit-commands-search.c
156-===================================================================
157---- gedit-3.21.90.orig/gedit/gedit-commands-search.c
158-+++ gedit-3.21.90/gedit/gedit-commands-search.c
159-@@ -174,12 +174,11 @@ forward_search_finished (GtkSourceSearch
160- GtkTextIter match_start;
161- GtkTextIter match_end;
162-
163-- found = gtk_source_search_context_forward_finish2 (search_context,
164-- result,
165-- &match_start,
166-- &match_end,
167-- NULL,
168-- NULL);
169-+ found = gtk_source_search_context_forward_finish (search_context,
170-+ result,
171-+ &match_start,
172-+ &match_end,
173-+ NULL);
174-
175- buffer = gtk_source_search_context_get_buffer (search_context);
176-
177-@@ -280,12 +279,11 @@ backward_search_finished (GtkSourceSearc
178- GtkTextIter match_end;
179- GtkSourceBuffer *buffer;
180-
181-- found = gtk_source_search_context_backward_finish2 (search_context,
182-- result,
183-- &match_start,
184-- &match_end,
185-- NULL,
186-- NULL);
187-+ found = gtk_source_search_context_backward_finish (search_context,
188-+ result,
189-+ &match_start,
190-+ &match_end,
191-+ NULL);
192-
193- buffer = gtk_source_search_context_get_buffer (search_context);
194-
195-@@ -424,12 +422,12 @@ do_replace (GeditReplaceDialog *dialog,
196-
197- gtk_text_buffer_get_selection_bounds (GTK_TEXT_BUFFER (doc), &start, &end);
198-
199-- gtk_source_search_context_replace2 (search_context,
200-- &start,
201-- &end,
202-- unescaped_replace_text,
203-- -1,
204-- &error);
205-+ gtk_source_search_context_replace (search_context,
206-+ &start,
207-+ &end,
208-+ unescaped_replace_text,
209-+ -1,
210-+ &error);
211-
212- g_free (unescaped_replace_text);
213-
214-Index: gedit-3.21.90/gedit/gedit-view-frame.c
215-===================================================================
216---- gedit-3.21.90.orig/gedit/gedit-view-frame.c
217-+++ gedit-3.21.90/gedit/gedit-view-frame.c
218-@@ -323,12 +323,11 @@ start_search_finished (GtkSourceSearchCo
219- gboolean found;
220- GtkSourceBuffer *buffer;
221-
222-- found = gtk_source_search_context_forward_finish2 (search_context,
223-- result,
224-- &match_start,
225-- &match_end,
226-- NULL,
227-- NULL);
228-+ found = gtk_source_search_context_forward_finish (search_context,
229-+ result,
230-+ &match_start,
231-+ &match_end,
232-+ NULL);
233-
234- buffer = gtk_source_search_context_get_buffer (search_context);
235-
236-@@ -387,12 +386,11 @@ forward_search_finished (GtkSourceSearch
237- GtkTextIter match_end;
238- gboolean found;
239-
240-- found = gtk_source_search_context_forward_finish2 (search_context,
241-- result,
242-- &match_start,
243-- &match_end,
244-- NULL,
245-- NULL);
246-+ found = gtk_source_search_context_forward_finish (search_context,
247-+ result,
248-+ &match_start,
249-+ &match_end,
250-+ NULL);
251-
252- if (found)
253- {
254-@@ -445,12 +443,11 @@ backward_search_finished (GtkSourceSearc
255- gboolean found;
256- GtkSourceBuffer *buffer;
257-
258-- found = gtk_source_search_context_backward_finish2 (search_context,
259-- result,
260-- &match_start,
261-- &match_end,
262-- NULL,
263-- NULL);
264-+ found = gtk_source_search_context_backward_finish (search_context,
265-+ result,
266-+ &match_start,
267-+ &match_end,
268-+ NULL);
269-
270- buffer = gtk_source_search_context_get_buffer (search_context);
271-
272
273=== modified file 'debian/patches/series'
274--- debian/patches/series 2016-09-18 20:37:48 +0000
275+++ debian/patches/series 2016-11-02 11:42:07 +0000
276@@ -4,5 +4,3 @@
277 05_menu_label.patch
278 08_multiarch_fallback.patch
279 unity_no_csd.patch
280-git_revert_gtk322.patch
281-git_revert_gtksourceview322.patch

Subscribers

People subscribed via source and target branches