Merge lp:~fitojb/unity-2d/kill-unused-assets into lp:unity-2d

Proposed by Adolfo Jayme Barrientos
Status: Merged
Approved by: MichaƂ Sawicz
Approved revision: 948
Merged at revision: 961
Proposed branch: lp:~fitojb/unity-2d/kill-unused-assets
Merge into: lp:unity-2d
Diff against target: 126 lines (+0/-103)
2 files modified
shell/dash/Home.qml (+0/-6)
shell/dash/HomeShortcuts.qml (+0/-97)
To merge this branch: bzr merge lp:~fitojb/unity-2d/kill-unused-assets
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
Review via email: mp+95718@code.launchpad.net

Commit message

[dash] Remove HomeShortcuts.qml and related assets

Description of the change

HomeShortcuts.qml is now unnecessary. As a result we can make Precise ISOs leaner by removing the unused asset files.

To post a comment you must log in.
Revision history for this message
Gerry Boland (gerboland) wrote :

Thanks for this, however these assets are still referred to by HomeShortcuts.qml. It is best to remove HomeShortcuts.qml and the assets all in one go. I have Tiago Herrmann doing it now. Watch this space!

Revision history for this message
Adolfo Jayme Barrientos (fitojb) wrote :

OK, I've now merged Tiago's branch, thank you for your help!

Revision history for this message
Gerry Boland (gerboland) wrote :

Great, thanks to you and Tiago! Approving

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity-2d/168/console reported an error when processing this lp:~fitoschido/unity-2d/kill-unused-assets branch.
Not merging it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'shell/dash/Home.qml'
2--- shell/dash/Home.qml 2012-02-01 23:52:38 +0000
3+++ shell/dash/Home.qml 2012-03-05 20:07:22 +0000
4@@ -187,11 +187,5 @@
5 anchors.fill: parent
6 source: "HomeShortcutsCustomized.qml"
7 }
8- Loader {
9- id: defaultShortcutsLoader
10- focus: !customShortcutsLoader.focus
11- anchors.fill: parent
12- source: (customShortcutsLoader.status == Loader.Error) ? "HomeShortcuts.qml" : ""
13- }
14 }
15 }
16
17=== removed file 'shell/dash/HomeShortcuts.qml'
18--- shell/dash/HomeShortcuts.qml 2012-02-08 12:18:08 +0000
19+++ shell/dash/HomeShortcuts.qml 1970-01-01 00:00:00 +0000
20@@ -1,97 +0,0 @@
21-/*
22- * This file is part of unity-2d
23- *
24- * Copyright 2010-2011 Canonical Ltd.
25- *
26- * This program is free software; you can redistribute it and/or modify
27- * it under the terms of the GNU General Public License as published by
28- * the Free Software Foundation; version 3.
29- *
30- * This program is distributed in the hope that it will be useful,
31- * but WITHOUT ANY WARRANTY; without even the implied warranty of
32- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
33- * GNU General Public License for more details.
34- *
35- * You should have received a copy of the GNU General Public License
36- * along with this program. If not, see <http://www.gnu.org/licenses/>.
37- */
38-
39-import QtQuick 1.0
40-import Unity2d 1.0
41-
42-Item {
43- anchors.fill: parent
44- anchors.topMargin: 21
45- anchors.bottomMargin: 35
46- anchors.leftMargin: 46
47- anchors.rightMargin: 32
48-
49- Grid {
50- id: buttons
51-
52- // FIXME Need this invisible Rectangle so that alignment in RTL is not broken and tests pass.
53- // Gerry says the Home lens is going away so we do not care about a better fix
54- // Don't ask me why the transparent Rectangle fixes the alignment though
55- Rectangle {
56- anchors.fill: parent
57- opacity: 0
58- }
59-
60- anchors.fill: parent
61- spacing: 51
62- columns: 4
63- rows: 2
64-
65- HomeButton {
66- focus: true
67- label: u2d.tr("Media Apps")
68- icon: "artwork/find_media_apps.png"
69- onClicked: activateLensWithOptionFilter("applications.lens", "type", "media")
70- }
71-
72- HomeButton {
73- label: u2d.tr("Internet Apps")
74- icon: "artwork/find_internet_apps.png"
75- onClicked: activateLensWithOptionFilter("applications.lens", "type", "internet")
76- }
77-
78- HomeButton {
79- label: u2d.tr("More Apps")
80- icon: "artwork/find_more_apps.png"
81- onClicked: activateLensAndClearFilter("applications.lens", "type")
82- }
83-
84- HomeButton {
85- label: u2d.tr("Find Files")
86- icon: "artwork/find_files.png"
87- onClicked: activateLens("files.lens")
88- }
89-
90- /* FIXME: use user's preferred applications instead of hardcoding them */
91- HomeButtonDefaultApplication {
92- label: u2d.tr("Browse the Web")
93- contentType: "x-scheme-handler/http"
94- }
95-
96- HomeButtonDefaultApplication {
97- label: u2d.tr("View Photos")
98- contentType: "image/jpeg"
99- desktopFile: "shotwell-viewer.desktop"
100- }
101-
102- HomeButtonDefaultApplication {
103- label: u2d.tr("Check Email")
104- contentType: "x-scheme-handler/mailto"
105- }
106-
107- HomeButtonDefaultApplication {
108- label: u2d.tr("Listen to Music")
109- contentType: "audio/x-vorbis+ogg"
110- }
111- }
112-
113- FocusPath {
114- item: buttons
115- columns: buttons.columns
116- }
117-}
118
119=== removed file 'shell/dash/artwork/find_files.png'
120Binary files shell/dash/artwork/find_files.png 2011-11-09 12:47:37 +0000 and shell/dash/artwork/find_files.png 1970-01-01 00:00:00 +0000 differ
121=== removed file 'shell/dash/artwork/find_internet_apps.png'
122Binary files shell/dash/artwork/find_internet_apps.png 2011-11-09 12:47:37 +0000 and shell/dash/artwork/find_internet_apps.png 1970-01-01 00:00:00 +0000 differ
123=== removed file 'shell/dash/artwork/find_media_apps.png'
124Binary files shell/dash/artwork/find_media_apps.png 2011-11-09 12:47:37 +0000 and shell/dash/artwork/find_media_apps.png 1970-01-01 00:00:00 +0000 differ
125=== removed file 'shell/dash/artwork/find_more_apps.png'
126Binary files shell/dash/artwork/find_more_apps.png 2011-11-09 12:47:37 +0000 and shell/dash/artwork/find_more_apps.png 1970-01-01 00:00:00 +0000 differ

Subscribers

People subscribed via source and target branches