Merge ~fheimes/ubuntu/+source/s390-tools:s390-tools-lp1903984-hirsute into ubuntu/+source/s390-tools:ubuntu/hirsute-devel

Proposed by Frank Heimes
Status: Merged
Merge reported by: Frank Heimes
Merged at revision: 29415f320383d8d21b2133920e32ba791d3353a7
Proposed branch: ~fheimes/ubuntu/+source/s390-tools:s390-tools-lp1903984-hirsute
Merge into: ubuntu/+source/s390-tools:ubuntu/hirsute-devel
Diff against target: 80 lines (+58/-0)
3 files modified
debian/changelog (+8/-0)
debian/patches/s390-tools-lp1903984-hirsute.patch (+49/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Lukas Märdian (community) Approve
Review via email: mp+396521@code.launchpad.net

Description of the change

debian/patches/s390-tools-lp1903984-hirsute.patch
  zcryptstats: Fix handling of partial results with many domains
  - zconf/zcrypt/zcryptstats.c: code fix to pass the correct next-domain
    to the subsequent CHSC call of a partial response

Test build is available here:
https://launchpad.net/~fheimes/+archive/ubuntu/lp1903984

To post a comment you must log in.
Revision history for this message
Lukas Märdian (slyon) wrote :

Thank you for preparing this patch! I like the extensive DEP-3 patch headers.
Code-wise it's a direct copy of upstream's patch and passes the build.

LGTM! uploaded to hirsute-proposed.

review: Approve
Revision history for this message
Frank Heimes (fheimes) wrote :

Many thx for the review, approval and the upload to hirsute-proposed!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 0145cf7..6139441 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+s390-tools (2.15.1-0ubuntu6) hirsute; urgency=medium
7+
8+ * debian/patches/s390-tools-lp1903984-hirsute.patch
9+ zcryptstats: Fix handling of partial results with many domains
10+ Thanks to Ingo Franzki (LP: #1903984)
11+
12+ -- Frank Heimes <frank.heimes@canonical.com> Tue, 19 Jan 2021 18:58:26 +0100
13+
14 s390-tools (2.15.1-0ubuntu5) hirsute; urgency=medium
15
16 * No-change rebuild to bring the version in sync with
17diff --git a/debian/patches/s390-tools-lp1903984-hirsute.patch b/debian/patches/s390-tools-lp1903984-hirsute.patch
18new file mode 100644
19index 0000000..fc4952f
20--- /dev/null
21+++ b/debian/patches/s390-tools-lp1903984-hirsute.patch
22@@ -0,0 +1,49 @@
23+Description: zcryptstats fails
24+ The zcryptstats tool reports data for only the last two domain IDs.
25+ Further, it hangs if one collect data for a complete crypto card,
26+ and then one has to kill the ssh session to get back.
27+ Patch/commit is:
28+ cf2311f cf2311f1f1de17435b49ba8c8697be91705ba031
29+ "zcryptstats: Fix handling of partial results with many domains"
30+ - zconf/zcrypt/zcryptstats.c: code fix to pass the correct next-domain
31+ to the subsequent CHSC call of a partial response
32+Author: Ingo Franzki <ifranzki@linux.ibm.com>
33+Origin: https://github.com/ibm-s390-tools/s390-tools/commit/cf2311f1f1de17435b49ba8c8697be91705ba031
34+Bug-IBM: IBM Bugzilla 189183
35+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1903984
36+Forwarded: not-needed
37+Applied-Upstream: upstream accepted with > v2.15.1
38+Reviewed-by: Frank Heimes <frank.heimes@canonical.com>
39+Last-Update: 2021-01-19
40+---
41+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
42+--- a/zconf/zcrypt/zcryptstats.c
43++++ b/zconf/zcrypt/zcryptstats.c
44+@@ -1178,8 +1178,14 @@
45+ scdmd_area.request.header.code = 0x102d;
46+ scdmd_area.request.header.length =
47+ sizeof(struct chsc_scdmd_request);
48+- scdmd_area.request.first_drid.ap_index = card;
49+- scdmd_area.request.first_drid.domain_index = g.min_domain;
50++ if (scdmd_area.response.p) {
51++ scdmd_area.request.first_drid =
52++ scdmd_area.response.crid;
53++ } else {
54++ scdmd_area.request.first_drid.ap_index = card;
55++ scdmd_area.request.first_drid.domain_index =
56++ g.min_domain;
57++ }
58+ scdmd_area.request.last_drid.ap_index = card;
59+ scdmd_area.request.last_drid.domain_index = g.max_domain;
60+ scdmd_area.request.s = 1;
61+@@ -1217,10 +1223,6 @@
62+ rc = process_apqn_measurement_data(&scdmd_area);
63+ if (rc != 0)
64+ break;
65+-
66+- if (scdmd_area.response.p)
67+- scdmd_area.request.first_drid =
68+- scdmd_area.response.crid;
69+ } while (scdmd_area.response.p);
70+
71+ return rc;
72diff --git a/debian/patches/series b/debian/patches/series
73index 7af9f39..73cfb59 100644
74--- a/debian/patches/series
75+++ b/debian/patches/series
76@@ -8,3 +8,4 @@ sg3-utils.patch
77 0001-dumpconf-Don-t-run-the-service-in-LXC.patch
78 update-install-paths.patch
79 0010-no-pie-is-not-a-valid-option-for-ld.patch
80+s390-tools-lp1903984-hirsute.patch

Subscribers

People subscribed via source and target branches