Merge ~fheimes/ubuntu/+source/s390-tools-signed:s390-tools-signed-sru-lp1942908-focal into ubuntu/+source/s390-tools-signed:ubuntu/focal-devel

[Frank Heimes]

s390-tools-signed-sru-lp1942908-focal
  * Rebuild against 2.12.0-0ubuntu3.4

Test build is available here:
https://launchpad.net/~fheimes/+archive/ubuntu/lp1942908

[Christian Ehrhardt  (paelzer)]

Hi, just a quick (read: maybe not completed, but hopefully helpful) review

1. The SRU template is missing at the bugs

2. you want to rebuild against a new version, but this is up to chance and luck right now
You'd want to force the d/control build dependency to bump from
  s390-tools-zkey (= 2.12.0-0ubuntu3.3)
to
  s390-tools-zkey (= 2.12.0-0ubuntu3.4)

That way in case publishing goes the wrong order it still will just wait to build until the other one is avaialble.

[Frank Heimes (fheimes)]

Thx for the first quick look at this.

I have a SRU Justification as draft, but I've sent it over to IBM (Marc) for review, since they need to do the testing (due to our lack of the correct hardware level: z15), but didn't received it back yet. Well, I didn't expected that this is picked up so quickly :-D

I've added a comment pointing to the PPA with all the test builds.

Well, but I don't really get or understand #2.
While I see a real installation issue in case the (separate !) s390-tools-signed package has a different version compared to s390-tools itself (which indeed always requires the alignment of the version of s390-tools-signed, so the 'version refresh' that I always do),
I don't get why a build dependency bump is needed for s390-tools-zkey (and I never had to do that before?!).

Compared to s390-tools-signed (which is indeed a separate package, with separate control file etc.), s390-tools-zkey is one of about 8 binary packages that is build based on the single s390-tools source package, and with that all these are defined in a single debian/control (so the s390-tool binary itself, but also s390-tools-zkey and more like s390-tools-cpuplugd, s390-tools-statd, etc.) and since they share the same control file, they will all automatically be build with the same version, no?
That is at least what one can see here:
https://launchpad.net/~fheimes/+archive/ubuntu/lp1942908/+sourcepub/12718034/+listing-archive-extra

[Lukas Märdian (slyon)]

We clarified the automatic build dependency, that is generated from d/control.in it will be fixed in the next upload.

+1

review: Approve

Unmerged commits

eab8a06... by Frank Heimes on 2021-09-23

  * Rebuild against 2.12.0-0ubuntu3.4

diff --git a/debian/changelog b/debian/changelog
index 8920bc4..f5f6577 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+s390-tools-signed (2.12.0-0ubuntu3.4) focal; urgency=medium
+
+  * Rebuild against 2.12.0-0ubuntu3.4
+
+ -- Frank Heimes <[e-mail]>  Thu, 23 Sep 2021 20:57:01 +0200
+
 s390-tools-signed (2.12.0-0ubuntu3.3) focal; urgency=medium
 
   * Rebuild against 2.12.0-0ubuntu3.3