Code review comment for lp:~fginther/unity/unity-revert-gtest

Didier Roche (didrocks) wrote :

Hum, the packaging is in bzr upstream, you can add the build-dep yourself now (which should have been better than reverting this). Anyway, let's try to fix this:
1. Why did it pass the pbuilder? Francis, I think that for packages with inline debian/, you should use the hook to install more build-dep for testing and just relying on the packaging one. Can you please tweak that? (That would have enabled us to fail in pbuilder, not launchpad)
2. I will ask to create a MIR (https://wiki.ubuntu.com/MainInclusionProcess) to get google-mock promoted to main for raring
3. Then, proposing a merge request adding those dep to the packaging and reverting this MR.

« Back to merge proposal