Merge lp:~fginther/ubuntu-filemanager-app/use-bzr-revno-in-version into lp:ubuntu-filemanager-app

Proposed by Francis Ginther
Status: Merged
Approved by: Francis Ginther
Approved revision: 228
Merged at revision: 228
Proposed branch: lp:~fginther/ubuntu-filemanager-app/use-bzr-revno-in-version
Merge into: lp:ubuntu-filemanager-app
Diff against target: 14 lines (+1/-1)
1 file modified
CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~fginther/ubuntu-filemanager-app/use-bzr-revno-in-version
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Review via email: mp+227055@code.launchpad.net

Commit message

Move manifest.json to manifest.json.in to allow for cmake configure_file(), to correct the presence of @BZR_REVNO@ in the version string.

Description of the change

Move manifest.json to manifest.json.in to allow for cmake configure_file().

This should correct the problem seen populating of @BZR_REVNO@ in the version string.

To post a comment you must log in.
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) :
review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2014-05-13 19:46:32 +0000
3+++ CMakeLists.txt 2014-07-16 16:00:20 +0000
4@@ -42,7 +42,7 @@
5 if(NOT BZR_REVNO)
6 set(BZR_REVNO "latest")
7 endif(NOT BZR_REVNO)
8- configure_file(manifest.json ${CMAKE_CURRENT_BINARY_DIR}/manifest.json)
9+ configure_file(manifest.json.in ${CMAKE_CURRENT_BINARY_DIR}/manifest.json)
10 install(FILES ${CMAKE_CURRENT_BINARY_DIR}/manifest.json apparmor.json ${CONTENT_HUB_EXPORTER} DESTINATION ${CMAKE_INSTALL_PREFIX})
11 else(CLICK_MODE)
12 execute_process(
13
14=== renamed file 'manifest.json' => 'manifest.json.in'

Subscribers

People subscribed via source and target branches