Merge lp:~fginther/ubuntu-filemanager-app/copy-Xauthority into lp:ubuntu-filemanager-app

Proposed by Francis Ginther
Status: Rejected
Rejected by: Michael Spencer
Proposed branch: lp:~fginther/ubuntu-filemanager-app/copy-Xauthority
Merge into: lp:ubuntu-filemanager-app
Diff against target: 25 lines (+4/-0)
2 files modified
debian/control (+1/-0)
tests/autopilot/ubuntu_filemanager_app/tests/test_filemanager.py (+3/-0)
To merge this branch: bzr merge lp:~fginther/ubuntu-filemanager-app/copy-Xauthority
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Ubuntu File Manager Developers Pending
Review via email: mp+183937@code.launchpad.net

Commit message

Copy .Xauthority file before patching HOME in autopilot tests. This allows the tests to run over an ssh session as is done by jenkins.

Description of the change

Copy .Xauthority file before patching HOME in autopilot tests. This allows the tests to run over an ssh session as is done by jenkins.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
61. By Francis Ginther

Add dependency on qtdeclarative5-localstorage-plugin.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

61. By Francis Ginther

Add dependency on qtdeclarative5-localstorage-plugin.

60. By Francis Ginther

Copy .Xauthority file before patching HOME.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-08-06 17:08:11 +0000
3+++ debian/control 2013-09-04 18:11:21 +0000
4@@ -12,6 +12,7 @@
5 Architecture: all
6 Depends: ${misc:Depends},
7 qmlscene,
8+ qtdeclarative5-localstorage-plugin,
9 qtdeclarative5-ubuntu-ui-toolkit-plugin | qt-components-ubuntu,
10 qtdeclarative5-qtquick2-plugin,
11 qtdeclarative5-nemo-qml-plugin-folderlistmodel
12
13=== modified file 'tests/autopilot/ubuntu_filemanager_app/tests/test_filemanager.py'
14--- tests/autopilot/ubuntu_filemanager_app/tests/test_filemanager.py 2013-08-15 22:08:28 +0000
15+++ tests/autopilot/ubuntu_filemanager_app/tests/test_filemanager.py 2013-09-04 18:11:21 +0000
16@@ -42,6 +42,9 @@
17
18 def _patch_home(self):
19 temp_dir = tempfile.mkdtemp()
20+ shutil.copyfile(
21+ os.path.expanduser(os.path.join('~', '.Xauthority')),
22+ os.path.join(temp_dir, '.Xauthority'))
23 self.addCleanup(shutil.rmtree, temp_dir)
24 patcher = mock.patch.dict('os.environ', {'HOME': temp_dir})
25 patcher.start()

Subscribers

People subscribed via source and target branches