Merge lp:~fginther/ubuntu-ci-services-itself/test-only-ticket-binaries into lp:ubuntu-ci-services-itself

[Francis Ginther]

Only pass the per-ticket binaries to the test-runner to avoid longer and longer test times.

Only pass the per-ticket binaries to the test-runner to avoid longer and longer test times.

This is a change to the original plan. Usability testing showed that the test-runner phase becomes very long after processing a few successful tickets. This change allows us to speed that up until we support something like running tests in parallel.

The old behavior can be re-created by just specifying multiple binaries when creating the ticket.

[Francis Ginther (fginther)]

Tested here:

http://15.125.109.157/ticket.html?ticket_id=2

The first test added lintian4python, the second added "python-bs4,python3-bs4". The test runner logs show that only python-bs4 and python3-bs4 were tested.

[Chris Johnston (cjohnston)]

review: Approve

=== modified file 'lander/bin/lander_service_wrapper.py'
--- lander/bin/lander_service_wrapper.py	2014-03-14 17:12:57 +0000
+++ lander/bin/lander_service_wrapper.py	2014-03-14 18:59:12 +0000
@@ -325,11 +325,18 @@
     # The queue should be unique
     queue = '%s-testrunner' % config['master']['progress_trigger']
     request_parameters = ticket.get_full_ticket()
+    packages = []
+    try:
+        packages = request_parameters.get('added_binaries', None).split(',')
+    except AttributeError:
+        # Expected when added_binaries is None.
+        pass
+
     params = {
         'ticket_id': config['master']['request_id'],
         'cancel_url': os.environ['BUILD_URL'] + 'api/json',
         'image_id': config['image_builder']['image_id'],
-        'package_list': _get_binary_packages(ticket, request_parameters),
+        'package_list': packages,
         'progress_trigger': queue,
     }
     ticket.set_testing_waiting()