Merge lp:~fginther/ubuntu-ci-services-itself/fix-ppa-sync into lp:ubuntu-ci-services-itself

Proposed by Chris Johnston
Status: Rejected
Rejected by: Francis Ginther
Proposed branch: lp:~fginther/ubuntu-ci-services-itself/fix-ppa-sync
Merge into: lp:ubuntu-ci-services-itself
Diff against target: 27 lines (+8/-12)
1 file modified
ppa-assigner/ppa_assigner/ppa_sync.py (+8/-12)
To merge this branch: bzr merge lp:~fginther/ubuntu-ci-services-itself/fix-ppa-sync
Reviewer Review Type Date Requested Status
Canonical CI Engineering Pending
Review via email: mp+210839@code.launchpad.net
To post a comment you must log in.

Unmerged revisions

380. By Francis Ginther

Remove the _should_update() check from ppa_sync. For this project, we always want to update.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ppa-assigner/ppa_assigner/ppa_sync.py'
2--- ppa-assigner/ppa_assigner/ppa_sync.py 2014-03-10 22:25:00 +0000
3+++ ppa-assigner/ppa_assigner/ppa_sync.py 2014-03-13 16:13:20 +0000
4@@ -134,15 +134,11 @@
5 '%s is not fully published in the source PPA', package)
6 continue
7
8- if _should_update(target_ppa, package, series, source_data['version']):
9- logging.info('Copying %s - %s for arches %s',
10- package, source_data['version'], arches_built)
11- target_ppa.syncSource(from_archive=ppa,
12- include_binaries=True,
13- source_name=package,
14- to_pocket='Release',
15- version=source_data['version'],
16- to_series=series.name)
17- else:
18- logging.info('Package %s - %s for arches %s already in target',
19- package, source_data['version'], arches_built)
20+ logging.info('Copying %s - %s for arches %s',
21+ package, source_data['version'], arches_built)
22+ target_ppa.syncSource(from_archive=ppa,
23+ include_binaries=True,
24+ source_name=package,
25+ to_pocket='Release',
26+ version=source_data['version'],
27+ to_series=series.name)

Subscribers

People subscribed via source and target branches