Sudoku App

Merge lp:~fginther/sudoku-app/fix-open-toolbar into lp:sudoku-app

  1. fix-open-toolbar
  2. Merge into trunk
Proposed by Francis Ginther
Status: Rejected
Rejected by: Alan Pope 🍺🐧🐱 🦄
Proposed branch: lp:~fginther/sudoku-app/fix-open-toolbar
Merge into: lp:sudoku-app
Diff against target: 22 lines (+11/-0) (has conflicts)
1 file modified
tests/autopilot/sudoku_app/emulators/ubuntusdk.py (+11/-0)
Text conflict in tests/autopilot/sudoku_app/emulators/ubuntusdk.py
To merge this branch: bzr merge lp:~fginther/sudoku-app/fix-open-toolbar
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Review via email: mp+181388@code.launchpad.net

Commit message

This is a MP for testing jenkins, PLEASE DO NOT MERGE.

Description of the change

This is a MP for testing jenkins, PLEASE DO NOT MERGE.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:104
http://91.189.93.70:8080/job/sudoku-app-ci/2/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/sudoku-app-precise-amd64-ci/2/console
    FAILURE: http://91.189.93.70:8080/job/sudoku-app-quantal-amd64-ci/2/console
    FAILURE: http://91.189.93.70:8080/job/sudoku-app-raring-amd64-ci/2/console
    FAILURE: http://91.189.93.70:8080/job/sudoku-app-saucy-amd64-ci/2/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/sudoku-app-ci/2/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:104
http://91.189.93.70:8080/job/sudoku-app-ci/2/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests/10/console
    FAILURE: http://91.189.93.70:8080/job/sudoku-app-precise-amd64-ci/2/console
    FAILURE: http://91.189.93.70:8080/job/sudoku-app-quantal-amd64-ci/2/console
    FAILURE: http://91.189.93.70:8080/job/sudoku-app-raring-amd64-ci/2/console
    FAILURE: http://91.189.93.70:8080/job/sudoku-app-saucy-amd64-ci/2/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/sudoku-app-ci/2/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:104
http://91.189.93.70:8080/job/sudoku-app-ci/4/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests/34/console
    FAILURE: http://91.189.93.70:8080/job/sudoku-app-precise-amd64-ci/4/console
    FAILURE: http://91.189.93.70:8080/job/sudoku-app-quantal-amd64-ci/4/console
    FAILURE: http://91.189.93.70:8080/job/sudoku-app-raring-amd64-ci/4/console
    FAILURE: http://91.189.93.70:8080/job/sudoku-app-saucy-amd64-ci/4/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/sudoku-app-ci/4/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

104. By Francis Ginther

Add animating wait_for to open_toolbar.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/sudoku_app/emulators/ubuntusdk.py'
2--- tests/autopilot/sudoku_app/emulators/ubuntusdk.py 2013-08-20 15:40:09 +0000
3+++ tests/autopilot/sudoku_app/emulators/ubuntusdk.py 2013-08-21 19:19:35 +0000
4@@ -119,7 +119,18 @@
5
6 def open_toolbar(self):
7 """Open the toolbar"""
8+<<<<<<< TREE
9 panel = self.app.select_single("Toolbar")
10+=======
11+ toolbar = self.get_toolbar()
12+ toolbar.animating.wait_for(False)
13+ if not toolbar.opened:
14+ self._drag_to_open_toolbar()
15+ toolbar.opened.wait_for(True)
16+ toolbar.animating.wait_for(False)
17+
18+ def _drag_to_open_toolbar(self):
19+>>>>>>> MERGE-SOURCE
20 qmlView = self.get_qml_view()
21
22 lineX = int(qmlView.x + qmlView.width * 0.50)

Subscribers

People subscribed via source and target branches