Merge lp:~fginther/sudoku-app/add-autopilot-package into lp:sudoku-app

Proposed by Francis Ginther
Status: Merged
Merged at revision: 79
Proposed branch: lp:~fginther/sudoku-app/add-autopilot-package
Merge into: lp:sudoku-app
Diff against target: 21 lines (+9/-0)
2 files modified
debian/control (+8/-0)
debian/sudoku-app-autopilot.install (+1/-0)
To merge this branch: bzr merge lp:~fginther/sudoku-app/add-autopilot-package
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Dinko Osmankovic Approve
Review via email: mp+174526@code.launchpad.net

Commit message

Adding sudoku-app-autopilot package to install autopilot UI tests.

Description of the change

Adding sudoku-app-autopilot package to install autopilot UI tests.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Dinko Osmankovic (dinko-metalac) :
review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
David Planella (dpm) wrote :

Hi Dinko, is there any particular reason why you set the MP manually back to Approved?

Generally, once it's been top approved, Jenkins takes care of the merging. Looking at the branch, Jenkins already merged it, so there's no need to re-approve it. If anything's not clear in the workflow, let me know and I'll be happy to clarify. Thanks!

Revision history for this message
David Planella (dpm) wrote :

Hm, my bad, sorry. I now understand why you made it. Just noticed the "Needs Fixing" from Jenkins.

However, it seems that Jenkins merged it despite complaining. We might just need to check with Francis Ginther on Monday to see what went on here. Keep up the good work!

Revision history for this message
Dinko Osmankovic (dinko-metalac) wrote :

Have no idea why it failed in the first place. Looking at the errors doesn't say anything.

As of reviewing, I made it by mistake. Didn't see Jenkins at all. My bad.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-06-14 07:56:11 +0000
3+++ debian/control 2013-07-13 03:43:29 +0000
4@@ -21,3 +21,11 @@
5 qtdeclarative5-xmllistmodel-plugin,
6 Description: Sudoku game for Ubuntu devices
7 Simple Sudoku Touch game written in QML2/JS using Ubuntu SDK
8+
9+Package: sudoku-app-autopilot
10+Architecture: all
11+Depends: libautopilot-qt,
12+ libqt5test5,
13+ sudoku-app (= ${source:Version})
14+Description: Autopilot UI tests for sudoku game for Ubuntu devices
15+ This package contains the autopilot tests for the Sudoku App
16
17=== added file 'debian/sudoku-app-autopilot.install'
18--- debian/sudoku-app-autopilot.install 1970-01-01 00:00:00 +0000
19+++ debian/sudoku-app-autopilot.install 2013-07-13 03:43:29 +0000
20@@ -0,0 +1,1 @@
21+tests/autopilot/sudoku_app/* usr/lib/python2.7/dist-packages/sudoku_app/

Subscribers

People subscribed via source and target branches